Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path of queue storage file so it's not directly in the home dir #16

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

cfsmp3
Copy link

@cfsmp3 cfsmp3 commented Nov 9, 2021

Trivial change to change the notification queue path so it's not directly in the home dir.

Instead of

~/not.json

use

~/.cache/rofication/notifications.json

Also create the path if needed.

@cfsmp3 cfsmp3 requested a review from kgilmer November 10, 2021 01:22
@kgilmer
Copy link
Member

kgilmer commented Nov 10, 2021

Can you briefly mention what you did to verify the change works?

@cfsmp3
Copy link
Author

cfsmp3 commented Nov 10, 2021

Can you briefly mention what you did to verify the change works?

  • Stop existing rofication-daemon (the notification counter on the desktop immediately goes red)
  • Start modified one without the target directory existing at all, confirm that the directory now exists, the notification counters is again live (with 0 notifications since it there's nothing saved at the new location)
  • Send some notifications
  • Stop the daemon
  • cat the new file and verify that the notifications are saved there as expected
  • Restart the daemon, confirm that they are reloaded correctly

@kgilmer
Copy link
Member

kgilmer commented Nov 13, 2021

Perfect, thanks @cfsmp3

Copy link
Member

@kgilmer kgilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfsmp3 cfsmp3 merged commit 6d4673b into regolith-linux:master Nov 13, 2021
@kgilmer
Copy link
Member

kgilmer commented Nov 13, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants