Report a safari-specific test failure without halting all tests #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dy
approved these changes
May 14, 2018
Contributor
|
As far as we log them as failure I guess that is ok. 💃 |
Member
Author
|
Yeah, I don't love it. Didn't factor it out more so that it's easy to rip out if someone wants to improve things. 🙄 It's strictly a convenience so you can figure out more quickly what's passing or failing. WebGL seems vendor-specific enough that it's maybe more of a philosophical issue what it means for some particular tests to fail… like is accounting for safari's quirks the user's responsibility or regl's responsibility? 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #479, there's a safari-specific half float bug that brings tests to a halt. Rather than a new failure, I believe this is instead the result of a new check for behavior that does seem broken in safari: 75730b6#diff-6d2e0d9813eb0b2330521d6a391021d3R169
This PR doesn't fix anything (Babylon, for one, just detects safari and reverts from half_float to float, I believe) but instead triggers a test failure that doesn't halt all tests.
In particular, it just wraps the test in a try/catch and reports a failure if it catches anything.