Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tracking for retire events #1596

Merged
merged 1 commit into from
Nov 28, 2022
Merged

feat: add tracking for retire events #1596

merged 1 commit into from
Nov 28, 2022

Conversation

wgwz
Copy link
Contributor

@wgwz wgwz commented Nov 22, 2022

Description

Closes: regen-network/rnd-dev-team#1389

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed
  • once the PR is closed, set up backport PRs for redwood, hambach and optionally master (see below)

Setting up backport PRs

After merging your PR to dev, set up backports by doing the following:

  1. If your branch does not have merge commits, add the following comment to
    your PR:
  • If PR is a new feature: @Mergifyio backport redwood hambach.
  • If PR is a bug fix: @Mergifyio backport redwood hambach master.

  1. If your branch does have merge commits:

    a. Pull latest dev, hambach and redwood branches

    b. Create new branches for backports and merge dev (replace <PR#> with your PR #)

    git checkout -b hambach-backport-<PR#> hambach
git merge dev
git push origin hambach-backport-<PR#>
git checkout -b redwood-backport-<PR#> redwood
git merge dev
git push origin redwood-backport-<PR#>`

    c. Open new PRs in regen-web targeting hambach and redwood, respectively.

    d. If PR is a bug fix repeat the same process for master branch.

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

flagrede
flagrede approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

victordelval
victordelval approved these changes Nov 23, 2022
View reviewed changes
Copy link

@victordelval victordelval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wgwz wgwz merged commit bba7700 into kyle/1341-improving-tracking-metadata Nov 28, 2022
@wgwz wgwz deleted the kyle/1389-retirement-tracking branch November 28, 2022 16:12
wgwz added a commit that referenced this pull request Nov 28, 2022
@wgwz
feat: Add requested metadata to buy, send, and sell events (#1551)
d48e81d 
* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)
mergify bot pushed a commit that referenced this pull request Nov 28, 2022
@wgwz @mergify
feat: Add requested metadata to buy, send, and sell events (#1551)
df47047 
* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)
mergify bot pushed a commit that referenced this pull request Nov 28, 2022
@wgwz @mergify
feat: Add requested metadata to buy, send, and sell events (#1551)
59bec9c 
* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)
mergify bot pushed a commit that referenced this pull request Nov 28, 2022
@wgwz @mergify
feat: Add requested metadata to buy, send, and sell events (#1551)
0065bca 
* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)
wgwz added a commit that referenced this pull request Nov 28, 2022
@mergify @wgwz
feat: Add requested metadata to buy, send, and sell events (#1551) (#…
86a4ed8 
…1614)

* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)

Co-authored-by: Kyle Lawlor-Bagcal <[email protected]>
wgwz added a commit that referenced this pull request Nov 28, 2022
@mergify @wgwz
feat: Add requested metadata to buy, send, and sell events (#1551) (#…
1f740d9 
…1615)

* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)

Co-authored-by: Kyle Lawlor-Bagcal <[email protected]>
wgwz added a commit that referenced this pull request Nov 28, 2022
@mergify @wgwz
feat: Add requested metadata to buy, send, and sell events (#1551) (#…
e46849f 
…1616)

* chore: enable analytics in deploy preview environment

* fix: improve login track event for reliable address metadata

* Revert "fix: improve login track event for reliable address metadata"

This reverts commit 7726985.

* WIP: implement login event tracking with useEffect in wallet button

* Revert "WIP: implement login event tracking with useEffect in wallet button"

This reverts commit e60e213.

* Revert "Revert "fix: improve login track event for reliable address metadata""

This reverts commit 736b14d.

* feat: improve the metadata for the buy2 event

* fix: use the correct name for the login tracking event

* feat: create tracker module, useTracker hook and module for analytics events types

* fix: add type to login event

* fix: send credit class id more reliably in buy1 event

* fix: favor more reliable project id for buy2 event metadata

* feat: improve the type safety of the track function

* fix: use useCallback for tracker, improve buySuccess and buyFailure events

* feat: add sell1 and send1 event metadata

* feat: add metadata to sell2, sellSuccess and sellFailure events

* feat: clean up metadata for send1, send2, sendSuccess and sendFailure

* chore: dedupe tracker module types by extending interfaces

* chore: remove console.log statement

* fix: add project.name in buy metadata

* fix: clean up after rebasing

* fix: use UTC for login event timestamp

* chore: rename classIdName and classIdUrl

* fix: apply linting rules to finalizeConnection

* fix: reduce number of find calls for send credit onError/onSuccess callbacks

* chore: disable analytics in deploy previews

* feat: add tracking for retire events (#1596)

(cherry picked from commit d48e81d)

Co-authored-by: Kyle Lawlor-Bagcal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flagrede flagrede flagrede approved these changes

@victordelval victordelval victordelval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wgwz @flagrede @victordelval