Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update go version to 1.19 #1689

Merged
merged 4 commits into from
Dec 16, 2022
Merged

build: update go version to 1.19 #1689

merged 4 commits into from
Dec 16, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Dec 15, 2022

Description

Ref: regen-network/cosmos-sdk#49

Using go version 1.18 versus 1.19 with cosmos sdk v0.46 will produce different snapshot hashes. This pull request bumps all modules to use go 1.19 and updates the go version check to require go 1.19. Bumping the go version caused a lint warning to become an error so this pull request also replaces the use of io/ioutil with os.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #1689 (2889eb5) into main (807ca0f) will not change coverage.
The diff coverage is 88.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files         228      228           
  Lines       13600    13600           
=======================================
  Hits         9901     9901           
  Misses       2967     2967           
  Partials      732      732           
Impacted Files Coverage Δ
app/utils.go 0.00% <0.00%> (ø)
types/testutil/network/util.go 70.46% <100.00%> (ø)
x/ecocredit/base/client/utils.go 90.62% <100.00%> (ø)
x/ecocredit/basket/client/util.go 100.00% <100.00%> (ø)
x/ecocredit/marketplace/client/util.go 100.00% <100.00%> (ø)

@ryanchristo ryanchristo marked this pull request as ready for review December 15, 2022 02:25
@ryanchristo ryanchristo requested a review from a team December 15, 2022 02:25
@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Dec 15, 2022
Copy link
Member

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran ack "1\.18" locally to verify there wasn't any extraneous usage of 1.18.

lgtm! thanks @ryanchristo

@ryanchristo ryanchristo merged commit 3f7a601 into main Dec 16, 2022
@ryanchristo ryanchristo deleted the ryan/update-go-version branch December 16, 2022 02:22
mergify bot pushed a commit that referenced this pull request Dec 16, 2022
ryanchristo added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants