You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this._worker is only created if ximg diff is enabled. Since this._worker is used to relay the filtering messages, the filtering is not working if XIMGDiffConfig.enabled = false
Expected behavior
Filtering is working even with ximgdiff disabled.
Actual behavior
Filtering is not working with ximgdiff disabled.
The text was updated successfully, but these errors were encountered:
I'm using Loki for visual regression testing, but I'm using reg-cli for reporting, as some other Loki users are doing (found about reg-cli in this issue oblador/loki#76).
I'm experiencing the same issue with filtering, it would be helpful to have it working or at least have a workaround. Could someone please check on this?
Describe the bug
If
ximgdiff
is disabled inregconfig.json
, filtering in the generated HTML report is not working.Reproduced step
Check out
reg-cli-report-ui
, disable ximgdiffConfig indevelop/index.html
Start the dev env via
yarn start
. Filtering is not working.Cause
reg-cli-report-ui/src/worker-client.ts
Lines 44 to 46 in 73849df
this._worker
is only created if ximg diff is enabled. Sincethis._worker
is used to relay thefiltering
messages, the filtering is not working ifXIMGDiffConfig.enabled = false
Expected behavior
Filtering is working even with ximgdiff disabled.
Actual behavior
Filtering is not working with ximgdiff disabled.
The text was updated successfully, but these errors were encountered: