Fix 178: Add data type checking and validation while performing agent plan action #428

Sardhendu · 2023-07-03T06:33:40Z

Add data validation and test cases

TODO PR Review:

[DONE] Test plan with all available dataset
[Not Required] Remove redundancy with data loading with code reusability.
[Confirmed] confirm if the validation is at par with the different tasks.

Validates that all the label columns are Strict String: Pydatic BaseModel validation.
Validates Data format for all required data rows for seed.csv. Separate validation for each Task.
Adds validation that the column names in seed.csv matches the column names parsed from example_template.
Adds validation for parity between config/prompt/label and sed.csv label columns values.

src/autolabel/data_loaders/read_datasets.py

src/autolabel/data_loaders/validation.py

src/autolabel/data_loaders/__init__.py

src/autolabel/data_loaders/validation.py

nihit

lgtm!

nihit · 2023-07-07T22:16:37Z

src/autolabel/data_loaders/read_datasets.py

+from autolabel.configs import AutolabelConfig
+
+logger = logging.getLogger(__name__)
+from typing import Union


redundant import, this is already imported on line 1

Sardhendu added 8 commits June 29, 2023 00:02

Modularize data loader

eef8682

Add Dynamic schema validation

69fdd92

validation code with testcase

863f7e0

validate on plan

b1b3098

Add tabulate to requirements

d84b141

Add Label list validation

3020a41

minor corrections

6cf5930

update on set values

ce31925

nihit reviewed Jul 6, 2023

View reviewed changes

src/autolabel/data_loaders/__init__.py Outdated Show resolved Hide resolved

src/autolabel/data_loaders/__init__.py Show resolved Hide resolved

nihit reviewed Jul 6, 2023

View reviewed changes

Sardhendu added 3 commits July 6, 2023 18:51

Review works

03c4f8c

Add cached properties

3e8fc09

Update on review

200cbed

Sardhendu requested a review from nihit July 7, 2023 21:13

Add tabulate to dependencies

5e7418b

nihit approved these changes Jul 7, 2023

View reviewed changes

Sardhendu changed the title ~~Fix 178~~ Fix 178: Add data type checking and validation during plan Jul 7, 2023

Sardhendu changed the title ~~Fix 178: Add data type checking and validation during plan~~ Fix 178: Add data type checking and validation while performing agent plan action Jul 7, 2023

nihit merged commit 6ed14a5 into refuel-ai:main Jul 7, 2023
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 178: Add data type checking and validation while performing agent plan action #428

Fix 178: Add data type checking and validation while performing agent plan action #428

Sardhendu commented Jul 3, 2023 •

edited

Loading

nihit left a comment

nihit Jul 7, 2023

Fix 178: Add data type checking and validation while performing agent plan action #428

Fix 178: Add data type checking and validation while performing agent plan action #428

Conversation

Sardhendu commented Jul 3, 2023 • edited Loading

nihit left a comment

Choose a reason for hiding this comment

nihit Jul 7, 2023

Choose a reason for hiding this comment

Sardhendu commented Jul 3, 2023 •

edited

Loading