Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the labeled stats shown for labeled examples #334

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

rajasbansal
Copy link
Contributor

No description provided.

@rajasbansal rajasbansal requested a review from nihit June 15, 2023 19:00
@@ -127,7 +127,7 @@ def run(
for current_index in track_with_stats(
indices,
postfix_dict,
total=len(inputs),
total=len(inputs) - current_index,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "total=len(inputs) - current_index - 1"?

Copy link
Contributor

@Abhinav-Naikawadi Abhinav-Naikawadi Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if current_index is the last element that has been completed so far?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current index is the latest example which has not been labeled. So, if the first five examples have been labeled, the index would be 5 (0 indexing)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay never mind then!

@rajasbansal rajasbansal merged commit b25606b into main Jun 16, 2023
@rajasbansal rajasbansal deleted the fix_existing_task_numbers branch June 16, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants