Skip to content

adding optional field for FieldColumns #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oklex wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

adding optional field for FieldColumns #124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29159b5
adding optional field for FieldColumns
Nov 12, 2024
a5ae319
added omit empty
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions common/messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ type View struct {
Name string `json:"name" msgpack:"name"`
LayoutType string `json:"layout_type" msgpack:"layout_type"`
DefaultRequests []string `json:"default_requests" msgpack:"default_requests"`

// optional UI view settins: more exist on FE "LayoutOptions" but aren't all exposed via schema
FieldColumns int `json:"field_columns" msgpack:"field_columns"`
Copy link
Contributor

@josh-lc josh-lc Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oklex looks good, but if you want to omit the return values if there is no value lets do this and that should ensure we don't return a empty value to frontend

FieldColumns int json:"field_columns,omitempty" msgpack:"field_columns,omitempty"

}

// A request to get the schema required by the Extension for its configuration and requests.
Expand Down