Add patches to fix GHC 8.6.5 on MacOS Big Sur and up #810
Conversation
default.nix
Outdated
| haskell = super.haskell // { | ||
| compiler = super.haskell.compiler // super.lib.optionalAttrs (super.stdenv.isDarwin) { | ||
| ghc865 = super.haskell.compiler.ghc865.overrideAttrs (old: { | ||
| patches = (old.patches or []) ++ [ ./haskell-overlays/patches/ghc865/fix-big-sur.patch ]; |
There was a problem hiding this comment.
Can we put all the patches in the same place? some are defined here in the overlays and others are up around like 41.
There was a problem hiding this comment.
Generally I would like to have all compiler patches that we keep (in-repo) to be in a format like this
$GIT_REPO/haskell-overlays/patches/<ghcver>/<platform>/*.patch
or alternatively replace
$GIT_REPO/haskell-overlays/patches to just $GIT_REPO/patches
keeps away a ton of ugly directory tree layouts
There was a problem hiding this comment.
I didn't mean the patch files themselves, I meant the list of patches being applied to our compilers.
There was a problem hiding this comment.
Lines 41 to 45 in 5aa890f
There was a problem hiding this comment.
New commit should make this align more with what we're currently doing
Relevant PR from haskell gitlab https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3689
This allows us to properly load frameworks on Big Sur and up.