Hydration fixes #317
Merged
Hydration fixes #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/develop: (28 commits) Only allow jsaddle to load at most once Add runImmediateWidgetWithHeadAndBody; deprecate attachWidget'' Fix hydration tests broken by new dependent-sum/map bump dependent-map version bound Fix errors introduced by recent JSM and UnrunnableT changes Relax version bound for dependent-sum* Replace hackage link with badge Fix hlint Bump upper bounds Add some type annotations to the hydration tests which fail to infer now Fix hlint errors in Reflex.Dom.Prerender Remove comment with obsolete contraint Fix all the UnrunnableT instances Remove unused import Use ReaderT to derive more instances for UnrunnableT Abstract out unrunnable pattern Add DomRenderHook instance for UnrunnableT Fix recursive Prerender constraint Add back recursive Client constraint Fix path reference from reflex-platform ...
…dration-fixes * origin/aa-dependent-sum-0.5: Bump to dependent-sum 0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix hydration in the presence of executable-config, we add the option of marking tags with a "data-hydration-skip" attribute, and remove the "data-ssr" attribute from static rendering. Prior to this, tags without the "data-ssr" attribute would be skipped over by hydration, now that only occurs for tags with "data-hydration-skip", and everything else is matched. (We're still not yet checking to ensure attributes are equal.)
This seems to fix the interaction alongside the PR I'm about to make on Obelisk.