Skip to content

starlette over fastapi#5069

Merged
adhami3310 merged 17 commits intomainfrom
starlette-over-fastapi
Apr 25, 2025
Merged

starlette over fastapi#5069
adhami3310 merged 17 commits intomainfrom
starlette-over-fastapi

Conversation

@adhami3310
Copy link
Member

trying out

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #5069 will degrade performances by 3.07%

Comparing starlette-over-fastapi (258d7c3) with main (3bcf01d)

Summary

❌ 1 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_get_all_imports[_simple_page] 461.9 µs 476.6 µs -3.07%

@adhami3310
Copy link
Member Author

this is a breaking change, would need to wait until 0.8.0dev for merging

@adhami3310 adhami3310 marked this pull request as ready for review April 18, 2025 20:35
@adhami3310 adhami3310 merged commit 71c1de6 into main Apr 25, 2025
41 of 42 checks passed
@adhami3310 adhami3310 deleted the starlette-over-fastapi branch April 25, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants