Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4578 - correct the way dim_props created #4587

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

KanvaBhatia
Copy link
Contributor

@KanvaBhatia KanvaBhatia commented Jan 4, 2025

Fixes #4578
instead of using the following -

dim_props = {
    "width": width or "100%",
    "height": height or "100%",
}

changing it to the following works

dim_props = {
    "width": width if width is not None else "100%",
    "height": height if height is not None else "100%",
}

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Bug fix Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

@KanvaBhatia KanvaBhatia marked this pull request as draft January 4, 2025 10:12
@KanvaBhatia KanvaBhatia marked this pull request as ready for review January 4, 2025 10:15
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@picklelo picklelo merged commit ab4e05b into reflex-dev:main Jan 5, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add variable height/width property for charts
2 participants