[wip] Pydantic v2 #2751
[wip] Pydantic v2 #2751
Conversation
Alek99
added
enhancement
benedikt-bartscher
force-pushed
the
pydantic-v2
branch
4 times, most recently
from
79c82a0
to
1934f57
Compare
| @@ -271,11 +277,18 @@ def __init__(self, *args, **kwargs): | |||
| field_type = EventChain | |||
| elif key in props: | |||
| # Set the field type. | |||
| field_type = fields[key].type_ | |||
| field_type = fields[key].annotation | |||
There was a problem hiding this comment.
in other places in the code annotation seems to be a function? 🤔 not sure if this is incorrect, but leaving myself a bookmark with this comment
There was a problem hiding this comment.
Yeah, cs_obj = field.annotation() is there to initialize default values iirc. Maybe pydantic provides smth like get_field_default which handles default and default_factorys for us?
| return super().get_value(value.__wrapped__) | ||
| return super().get_value(value) | ||
|
|
||
| def _get_value(self, value: Any, **kwargs) -> Any: |
There was a problem hiding this comment.
why a new function? is this just WiP artifacts?
There was a problem hiding this comment.
_get_value is there to allow unwrapping the MutableProxys in pydantics serialization. There should be a better way to do this.
Funny sidenote: While _get_value is deprecated by pydantic, they somehow seem to rely on it for serialization.
benedikt-bartscher
force-pushed
the
pydantic-v2
branch
3 times, most recently
from
f74f33d
to
1dea3b1
Compare
benedikt-bartscher
force-pushed
the
pydantic-v2
branch
from
141be37
to
16a7c1f
Compare
|
@masenf should we revisit this? Or do you plan to migrate |
#1539
Heavily inspired by @masenf's pydantic branch (https://github.com/reflex-dev/reflex/tree/masenf/pydantic-v2)