Skip to content

Commit

Permalink
add evaluate time to the progress counter (#4722)
Browse files Browse the repository at this point in the history
  • Loading branch information
adhami3310 authored Feb 1, 2025
1 parent 80a26b4 commit 3cb4443
Showing 1 changed file with 22 additions and 11 deletions.
33 changes: 22 additions & 11 deletions reflex/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -958,20 +958,16 @@ def get_compilation_time() -> str:

should_compile = self._should_compile()

for route in self._unevaluated_pages:
console.debug(f"Evaluating page: {route}")
self._compile_page(route, save_page=should_compile)
if not should_compile:
for route in self._unevaluated_pages:
console.debug(f"Evaluating page: {route}")
self._compile_page(route, save_page=should_compile)

# Add the optional endpoints (_upload)
self._add_optional_endpoints()
# Add the optional endpoints (_upload)
self._add_optional_endpoints()

if not should_compile:
return

self._validate_var_dependencies()
self._setup_overlay_component()
self._setup_error_boundary()

# Create a progress bar.
progress = Progress(
*Progress.get_default_columns()[:-1],
Expand All @@ -980,16 +976,31 @@ def get_compilation_time() -> str:
)

# try to be somewhat accurate - but still not 100%
adhoc_steps_without_executor = 6
adhoc_steps_without_executor = 7
fixed_pages_within_executor = 5
progress.start()
task = progress.add_task(
f"[{get_compilation_time()}] Compiling:",
total=len(self._pages)
+ (len(self._unevaluated_pages) * 2)
+ fixed_pages_within_executor
+ adhoc_steps_without_executor,
)

for route in self._unevaluated_pages:
console.debug(f"Evaluating page: {route}")
self._compile_page(route, save_page=should_compile)
progress.advance(task)

# Add the optional endpoints (_upload)
self._add_optional_endpoints()

self._validate_var_dependencies()
self._setup_overlay_component()
self._setup_error_boundary()

progress.advance(task)

# Get the env mode.
config = get_config()

Expand Down

0 comments on commit 3cb4443

Please sign in to comment.