Implement Page.rebuild! so that invalid url cache is cleared on re-sort

[joemsak]

All tests passing on my end, and confirmed this fixed the problem I was having

When re-sorting pages, the URL in the front-end was not updating to the correct path

Now it does with this .rebuild! class method

[joemsak]

This possibly fixes the other issue properly without having to use page id in the admin edit URLs HOWEVER:

Since the page tree is not returned / refreshed, that would still have to be addressed to put friendly URLs back into the admin

[travisbot]

This pull request passes (merged 174545f into e32ba57).

[ugisozols]

I must be missing something but how would this plain implementation of rebuild! fix cached page urls? I mean where is it called when you reorder pages?

Although it would be really cool to have some specs for this.

[joemsak]

Called at the end of update_positions

https://github.com/resolve/refinerycms/blob/master/core/lib/refinery/crud.rb#L291

The problem being addressed was that after re-sorting, pages retained their old URLs in the front end (though they appeared in the right place in the menu)

Calling this method made that issue go away for us

[parndt]

The logic seems a bit funny.. you're calling all and then looping through each page and its children when they're already contained inside the all result set.

[parndt]

@joemsak @ugisozols @robyurkowski I've opened #1706 to replace this pull request because I wanted to suggest an alternative which would make more sense to me..

[joemsak]

oh yea duh :P

On Friday, May 25, 2012 at 10:23 PM, Philip Arndt wrote:

@joemsak @ugisozols @robyurkowski I've opened #1706 to replace this pull request because I wanted to suggest an alternative which would make more sense to me..

---

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms/pull/1702#issuecomment-5944056