-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Invalid DOM after generate engine extension with :text fields #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
To aid in reproducing and debugging can you please give us the command you entered to generate the extension? Thanks! |
Yep, of course.
|
Conflicts: core/lib/generators/refinery/engine/templates/app/views/refinery/namespace/admin/plural_name/_form.html.erb Fixes #2236
Thanks, this wasn't an issue on master so I've pushed a solution already coded by @robyurkowski to 2-0-stable. Can you please try again using that? gem 'refinerycms', :github => 'refinery/refinerycms', :branch => '2-0-stable' |
👍 |
Hi everyone. This bug only appears when your engine have 2 or more :text fields. With strings attributes is alright.
When I generate an engine with 2 or more text fields (that can be edited with wymeditor), I got this invalid code in my
vendor/extensions/engine_name/app/views/.../admin/engine_name/_form.html.erb
partial:As you can see, one of closing divs is redundant and it causes some troubles in Chrome, for example I can not attach js script to this form, cause DOM is invalid. I have been searched in core code for this bug, but didn't find yet where it lives.
The text was updated successfully, but these errors were encountered: