New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poseStack translation leak in JEI RecipeTransferCraftingGridError #3718

Open

mezz wants to merge 1 commit into refinedmods:develop from mezz:jei-push-pop

mezz commented Jul 25, 2024 •

edited

Loading

Fix for

[Bug]: Visual Bug when hovering the "+" button in Refined Storage mezz/JustEnoughItems#3630

RS has a poseStack.translate with pushing and popping the stack, resulting in a leaked translation.

Before fix, hovering over the crafting button would shift GUI elements around:

After fix:

I added mitigation for this in JEI as well but I think this is the "correct" place for the fix to be.


          Fix poseStack translation leak in JEI RecipeTransferCraftingGridError

c41d3fa

mezz mentioned this pull request

[Bug]: Visual Bug when hovering the "+" button in Refined Storage mezz/JustEnoughItems#3630

Open

Author

mezz commented Jul 25, 2024 •

edited

Loading

Note this issue does not exist in refinedstorage-jei-integration for 1.21, the push and pop are there:
https://github.com/refinedmods/refinedstorage-jei-integration/blob/3ae49100628b59bee6c553e94f3ad4003e022755/refinedstorage-jei-integration-common/src/main/java/com/refinedmods/refinedstorage/jei/common/MissingItemRecipeTransferError.java#L49-L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet