Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have to reconnect external storage to drawer controller every time world loads #2636

Closed
onlyamonth opened this issue Jul 27, 2020 · 60 comments · Fixed by #3435
Closed

Have to reconnect external storage to drawer controller every time world loads #2636

onlyamonth opened this issue Jul 27, 2020 · 60 comments · Fixed by #3435
Labels
bug Something isn't working

Comments

@onlyamonth
Copy link

Issue description:
Have to reconnect external storage to drawer controller every time world loads

What happens:
Basically the same thing as #2120, but in 1.15.2

What you expected to happen:
Storage is seen on world load

Steps to reproduce:
Make a drawer controller and some drawers, connect to external storage
Put stuff in drawers, appears in grid
Reload world - drawer contents do not appear in grid
...
Version (make sure you are on the latest version before reporting):
Minecraft: 1.15.2
Forge: 31.2.21
Refined Storage: 1.8.8
Does this issue occur on a server? yes

Modpack: Valhelsia2 2.2.3, with latest versions of refined storage, addons and storage drawers.
@raoulvdberge
Copy link
Collaborator

Can you interact with the drawer controller with hoppers etc after world reload?

@onlyamonth
Copy link
Author

Yes, and that showed an interesting behaviour - the external bus sees items added to connected drawers after a new world load, but never gets the pre-existing item amounts. It's like it see's all the drawers, knows what goes in them, but thinks they're all empty.

It inserts into the drawers when new items are added via grid. You can extract those items again, but not any more than what you put in since world load, even if there are more in the drawers. Replacing the storage bus makes all existing items appear.

So, it seems on load it thinks the drawers are empty but knows what should go in them.

@LIMachi LIMachi mentioned this issue Sep 7, 2020
Closed
@eliminat eliminat mentioned this issue Nov 23, 2020
Closed
@MysticDaedra
Copy link

I have this same issue, currently playing the MC Eternal modpack (not sure if that matters or not). The issue is specifically External Storages and Drawer Controllers from Storage Drawers mod. My temporary fix is to break and replace the external storages after loading the world, but if I forget a lot of my machines will start to fill up my drive storage.

@allout58
Copy link

allout58 commented Dec 2, 2020

I have a similar issue in the AllTheMods6 pack. I've found if I just cycle through the import/export/both modes after startup, it solves the issue

This was referenced Dec 12, 2020
Closed
Closed
@tivec
Copy link

tivec commented Dec 14, 2020

Just to chime in, I'm seeing the same issue.

@joseph-p-pasaoa
Copy link

joseph-p-pasaoa commented Dec 18, 2020 •
edited
Loading

Same exact issue as @onlyamonth and others as above. I'm playing:
FTB Revelation (MC 1.12.2, Forge 14.23.5.2846) SINGLE PLAYER
Refined Storage 1.6.15
Storage Drawers 1.12.2-5.4.2
RebornStorage 3.3.4.1
Refined Storage Addons 0.4.4

Originally, my personal half-solution is a relay (off on rs signal) enroute to the Ext Storage with a button that have to press after every world start otherwise as stated by others the containers are seen but read as empty. Items that my mob farm feeds into the drawers do actually show up after world start but the items that were in the drawers at world load are not visible until the inventory is re-checked like in my half-solution above.

I've been playing with the issue for the past hour reorienting the drawer controller, placing it in different locations, having the external storage connect to different faces but nothing has solved the issue yet. I isolated my refined storage to a RS Controller, Grid, and External Storage and the issue still happens. The drawers block as well as my RS system are all contained within one chunkloaded chunk. I've tried substituting Phantomfaces proxying the Drawer Controller connected to the Ext Storage instead, still fails.

I hope any of this helps. Let me know if there's anything I can do to help fig this out.

@joseph-p-pasaoa joseph-p-pasaoa mentioned this issue Dec 19, 2020
Open
@Darkere Darkere mentioned this issue Dec 24, 2020
Closed
@raoulvdberge raoulvdberge added the bug Something isn't working label Dec 24, 2020
@embeddedt embeddedt mentioned this issue Dec 26, 2020
Closed
@embeddedt
Copy link

embeddedt commented Dec 26, 2020 •
edited
Loading

Originally, my personal half-solution is a relay (off on rs signal) enroute to the Ext Storage with a button that have to press after every world start otherwise as stated by others the containers are seen but read as empty.

This is a smart workaround.

(As far as I know, 1.12 is not supported anymore by RS so this will never be fixed upstream in that version. However, https://github.com/tth05/morerefinedstorage might be willing to accept a backported fix if one is found for 1.15/1.16.)

@kamild1996
Copy link

kamild1996 commented Jan 3, 2021 •
edited
Loading

Confirmed it's still an issue on MC 1.16.4, All The Mods 6 1.3.7 (Refined Storage 1.9.9, Storage Drawers 8.2.1). Workarounds provided by others (reconnecting to drawer controller, redstone pulse, cycling through input/output modes or redstone modes) also work.

@embeddedt
Copy link

Can someone provide a world (ideally with only the most necessary mods installed) which can be used to reproduce this? I can't get this to happen with just RS and Storage Drawers.

@joseph-p-pasaoa
Copy link

joseph-p-pasaoa commented Jan 3, 2021 •
edited
Loading

I've discovered the chunk with the connection also needs to be chunk loaded using the FTB chunk loader. Any other chunkloader like chicken chunks won't replicate the issue

@embeddedt
Copy link

@joseph-p-pasaoa I've tried chunkloading the entire RS system and just the external storage/storage drawer part using FTB Utilities, however, the issue is still not happening. Is there anything else special about your system that might affect how chunk reloading works?

Any other chunkloader like chicken chunks won't replicate the issue

It would be interesting to see whether this is also true in the post-1.13 versions (as I believe chunkloading mechanics changed).

@V8gaming
Copy link

V8gaming commented Jan 4, 2021

I believe it happens with a large storage drawer, it works with like 1 & 8 but when its like 40 4x4 drawers it doesn't seem to load, maybe its a overload of some-sort.

@embeddedt
Copy link

@V8gaming Thanks for that tip; that means that the issue may be related to the storage drawer system overflowing into adjacent chunks. I'll experiment with a larger drawer setup.

@LunardH
Copy link

LunardH commented Jan 4, 2021

I've discovered the chunk with the connection also needs to be chunk loaded using the FTB chunk loader. Any other chunkloader like chicken chunks won't replicate the issue

I was chunk loading with chicken chunks and had the issue, removed my chunk loader and still have it, will try removing reborn storage as someone said it fixed for him but idk

@embeddedt
Copy link

I've experimented with some different setups and still haven't been able to replicate this. It would be very useful if someone could send a world which has the problem, otherwise I'm not sure I or anyone else will be able to fix the issue.

@LunardH
Copy link

LunardH commented Jan 4, 2021

I've experimented with some different setups and still haven't been able to replicate this. It would be very useful if someone could send a world which has the problem, otherwise I'm not sure I or anyone else will be able to fix the issue.

Can send u the mods and config folder and then my world for you to see, for now ive done the redstone signal thing but this gonna be crap whenever im not at the place

@embeddedt
Copy link

That'd be great!

@LunardH
Copy link

LunardH commented Jan 4, 2021

Here it is https://drive.google.com/file/d/13d4BJmLTHVEIfpaIo9A_ECBlhGFTbvNN/view?usp=sharing

@LunardH
Copy link

LunardH commented Jan 4, 2021

And Reborn Storage was not the problem in my case

@Wishbone1977
Copy link

Just for the record, I'm seeing the same thing in my single player world. It's my own 1.12.2 modpack, constructed through the CurseForge app. As others have mentioned in this and previous issues raised about the same problem, I also have my base chunkloaded with FTB Utilities. However, I have just run a series of tests, and the problem persists even though I have removed not only my base from the chunk loading, but removed all chunk loading altogether, including some chunks in the nether I had loaded.

I may try to make a copy of my pack, remove most of the other mods I have added to it, and then try to replicate the issue in a new world. If I manage to replicate it in a smaller world with fewer mods, I'll let you know.

@Wishbone1977
Copy link

Okay, so I've done a bit of testing, and have gotten some results.

I took a copy of my pack to mess around with, and tried running some tests with my existing world. After each change I made, I did a "Save & Quit" and then started the world again to see if the problem persisted.

  1. Uninstall FTB utilities altogether.
    Problem persists.
  2. Break and replace both the drawer controller and the external storage.
    Problem persists.
  3. Break both the drawer controller and the external storage and move them to the same chunk as the Refined Storage controller.
    Problem goes away.
  4. Break both the drawer controller and the external storage and move them back to where they were (neighboring chunk).
    Problem returns.

In other words, it looks very much like the problem is a cross-chunk issue of some kind. My storage controller is right up against a chunk border, and my wall of drawers is up against the same border, but on the other side of the border. My drawer controller was on the other side of the drawer wall, which is why I could simply move it to the near side of the wall instead and have it end up in the same chunk as the storage controller.

In all cases where the problem manifested itself, I could make it go away by flicking a lever placed on the block next to the external storage. It would then remain absent until the world was next reloaded.

Just to be absolutely sure, I went back to my original world (that still had FTB Utils installed), restored all the chunkloading I had before, and ran tests 2-4 again, with exactly the same results. While that doesn't rule out other mods as a possible source of the problem, FTB Utilities is certainly not to blame.

Let me know if there is anything else you would like me to test.

@LunardH
Copy link

LunardH commented Jan 5, 2021

@Wishbone1977 In your own world did the same chunk thing resolve the issue? Imma test it right now

@embeddedt
Copy link

Has anyone gotten this to happen with chests or is it limited to storage drawer controllers only?

@tivec
Copy link

tivec commented Jul 25, 2021

Has anyone gotten this to happen with chests or is it limited to storage drawer controllers only?

It is limited to a few storage blocks, StorageDrawer controllers are most common since they're something people use lots. The drawers themselves seem to work, so if you can put a storage bus on each...

@DizzyDJW
Copy link

There used to be a mod that added a block that could detect a specific player in a server and emit a redstone signal based on whether that player was there or not. Using that block you could just set it next to the External Storage and let it update the block for you.

@tivec
Copy link

tivec commented Jul 25, 2021

There used to be a mod that added a block that could detect a specific player in a server and emit a redstone signal based on whether that player was there or not. Using that block you could just set it next to the External Storage and let it update the block for you.

We have workarounds galore, but no fix for the problem. I'd rather have a fix to the bug.

@embeddedt
Copy link

Part of the problem with fixing this bug is that it doesn't seem to be reproducible in fresh worlds with small storage systems. I have tried a number of times over the last few months to reproduce this and haven't been successful.

Does anyone have a world in a relatively small modpack (less than 20 mods) that has this issue? Worlds from the big modpacks like ATM6 are unfortunately not that helpful for two reasons:

  • They take quite a long time to load.
  • It is usually very difficult to get all of the mods into a Forge development environment.

@Darkere
Copy link
Collaborator

Darkere commented Jul 25, 2021

If you attach a debugger to the running pack instead of loading completely from IDE (you need some special args for it) you can just debug RS + Storagedrawers.
(although performance is likely pretty bad).

@tivec
Copy link

tivec commented Jul 25, 2021

Part of the problem with fixing this bug is that it doesn't seem to be reproducible in fresh worlds with small storage systems. I have tried a number of times over the last few months to reproduce this and haven't been successful.

Does anyone have a world in a relatively small modpack (less than 20 mods) that has this issue? Worlds from the big modpacks like ATM6 are unfortunately not that helpful for two reasons:

  • They take quite a long time to load.

  • It is usually very difficult to get all of the mods into a Forge development environment.

I'm relatively certain it has been confirmed to happen when the storage controller and bus is in a chunk different from the RS controller, and it has been reproduced in smaller mod setups.

As said by the next post over, a debugger can be attached but it is still very tricky to track it down. I would help code wise, but again I have no dev environment nor forge dev experience.

@embeddedt
Copy link

Indeed, the number of reports alone confirms that it must be an issue, but there must be more to it than just the drawer controller and external storage bus in a separate chunk from the controller. Here is an example of one of the setups I tried in 1.12. I believe I tried this in 1.16 as well and got the same results.

image

Logging out and back in still displays the drawer items in the crafting grid.

@Darkere
Copy link
Collaborator

Darkere commented Jul 25, 2021

You might need to chunkload it using FTBChunks to get the error to occur.

@embeddedt
Copy link

I'm now trying in 1.16 but still can't get the exact behavior described in this issue to occur reliably.

What I have figured out is this: the controller does not attempt to keep loading the chunk the external storage interface and drawers are in. In a test setup where the controller and external storage were placed more than 1 render distance away from each other, I logged out while standing next to the controller, and when logging back in, the items in the drawers were no longer listed.

However, once I load the drawer controller and external storage interface with FTB Chunks, this issue goes away, and the system works normally, even after relogging.

@DizzyDJW
Copy link

DizzyDJW commented Jul 25, 2021 •
edited
Loading

My RS and Storage Drawers have ALWAYS been in the same chunk, to save on resources when keeping chunks loaded, so I can say without a doubt that having them in separate chunks is not the culprit.

However FTBChunks may somehow be affecting it negatively via the load order in which the chunks update, potentially, slower than RS blocks do. Just a theory, but I've never not had a chunk loader with my RS and SD setup.

@embeddedt
Copy link

I cannot get anything amiss to happen when everything is in one chunk. I'm convinced that the problem exists, but it refuses to appear in my test world.

@Sakata-MC
Copy link

Sakata-MC commented Jul 30, 2021 •
edited
Loading

Still ongoing in my ATM6 1.7.6 world. Not sure what the cause is, but just takes a break/replace fo the cable and it works until the server restarts.
Oddly doesn't occur with Dank storages, so may be something specifically with RS and SD.

@Wishbone1977
Copy link

You might need to chunkload it using FTBChunks to get the error to occur.

Nope, I replicated it consistently without FTB Utils installed: #2636 (comment)

@embeddedt
Copy link

Oddly doesn't occur with Dank storages, so may be something specifically with RS and SD.

I am wondering if the storage drawer controller takes an extra tick to actually display the right contents, but doesn't notify RS when it has updated its contents on that tick. That's just a guess, though.

@NiSiSuinegEht
Copy link

NiSiSuinegEht commented Sep 26, 2021 •
edited
Loading

I am experiencing this issue in Enigmatica E6 0.5.11. Entire drawer system and RS system are in the same FTBChunks loaded chunk. Have to break and re place external storage after server restarts. Breaking and re placing the drawer controller does not fix the problem, only the external storage.

@Sakata-MC
Copy link

Sakata-MC commented Sep 27, 2021 via email

@tivec
Copy link

tivec commented Sep 28, 2021

Feels like this could probably be solved if RS waited a second or so to allow the chunks to load before checking storage buses, but that might not work over chunk borders...

I dunno, I will use the workarounds for now. Maybe the multi block from the drawer controller is loaded later and that makes RS fail to see it.

If storage buses have a status if they are connected or not, maybe it would be possible to check if they aren't and then read the inventory?

@lachian lachian mentioned this issue Oct 15, 2021
Closed
@ZAKsPop
Copy link

ZAKsPop commented Oct 18, 2021

All my storage drawers and RS are in same chunk. Still happening. I don't break anything to restore it. I just change the mode of the external storage connector from "item" to "liquid" and back to "item". Fixes it. Still an annoyance.

@LunardH
Copy link

LunardH commented Oct 20, 2021

All my storage drawers and RS are in same chunk. Still happening. I don't break anything to restore it. I just change the mode of the external storage connector from "item" to "liquid" and back to "item". Fixes it. Still an annoyance.

Just make it block update like setting up a timer facing the external storage and it will never be a problem anymore

@tivec
Copy link

tivec commented Oct 20, 2021 via email

@NiSiSuinegEht
Copy link

I feel the simple solution would be for the external storage to trigger a bock update whenever it is queried by the controller.

@LunardH
Copy link

LunardH commented Oct 20, 2021

@tivec I know but i dont think we'll get any solution to this problem, its been an issue for so long now that i just give ppl the simplest option to "fix" the problem

@raoulvdberge
Copy link
Collaborator

Since the discussion in this thread isn't really valuable anymore for us in order to reproduce it, I'm going to lock this issue. If anyone has any good reproduction steps, feel free to send us a message.

@refinedmods refinedmods locked and limited conversation to collaborators Oct 21, 2021
@raoulvdberge
Copy link
Collaborator

Hi guys, this will be solved in the next version for RS (v1.11.3) on MC 1.19.2.

The fix will also be backported to 1.18.2 and will come to CurseForge soon.

embeddedt added a commit to embeddedt/morerefinedstorage that referenced this issue Dec 20, 2022
@embeddedt
Fix external storage desync issue
d924289 
Fixes refinedmods/refinedstorage#2120
Fixes refinedmods/refinedstorage#2636

Backport of refinedmods/refinedstorage#3435
embeddedt added a commit to embeddedt/ModernFix that referenced this issue Apr 8, 2023
@embeddedt
Fix refinedmods/refinedstorage#2636
4dd6b76 
Mixin version of refinedmods/refinedstorage#3435
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix External Storage on Storage Drawers desync on world load BlueAgent/refinedstorage