Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove items from RS grid #2568

Open
ocram9 opened this issue Jun 12, 2020 · 6 comments
Open

Can't remove items from RS grid #2568

ocram9 opened this issue Jun 12, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@ocram9
Copy link

ocram9 commented Jun 12, 2020

Issue description:

When I connect a dimstorage chest to my RS system using the external storage I can't take any items from my RS grid. Not just the items from the dimstorage chest. I already reported it on the dimstorage github but they told me I should contact you: Edivad99/DimStorage#27

Steps to reproduce:

  1. Connect a dimstorage chest to an RS system using external storage.
  2. Try to remove items from the RS system (not only the items from the chest but also from drives). If you're fast enough you might be able to take something once but not after that.

Versions:

  • Minecraft: 1.15.2
  • Forge: 31.2.9
  • Refined Storage: 1.8.4
  • DimStorage: 3.1.5

Does this issue occur on a server? [yes/no]
Yes

@Darkere
Copy link
Collaborator

Darkere commented Jun 12, 2020

Commented on the issue over at their github as the issue is at least 90% their fault.

I'm not certain how and if we can improve how we react to a NEIHBORS_CHANGED event.

@raoulvdberge raoulvdberge added bug Something isn't working Waiting labels Jun 15, 2020
@Darkere
Copy link
Collaborator

Darkere commented Jun 17, 2020

Some more looking at our side we do have a problem here.

We are currently reacting to any NEIGHBORS_CHANGED (this happens lots, for example when a player opens a chest) with invalidating the Storage cache. This was fine in 1.12, but in 1.15 this invalidation gives each stack a new UUID which in turn causes them to not be extractable from a grid.

Not seeing too many good solutions. Maybe we can call something else if the block state didn't change?

@GsakuL
Copy link

GsakuL commented Jul 25, 2020

Not sure, if it helps, but this also happens with Ender Chests from Ender Storage

Versions:

  • (Pack: Valhelsia 2 - 2.2.5a)
  • Minecraft: 1.15.2
  • Forge: 31.2.31
  • Refined Storage: 1.8.8
  • Ender Storage: 2.5.0.143

@AdamNisbett
Copy link

AdamNisbett commented Aug 31, 2020

For what it's worth, I also saw this issue when trying to connect with the Dank Storage mod.

Pack: Enigmatica 6 0.2.13
Minecraft 1.16.1
Forge 32.0.108
Refined Storage 1.9.2
refinedstorageaddons-0.7
dankstorage-3.8

@Famous5000
Copy link

Sorry to necro, but this issue is still present on ATM6:TTS. Using this with Compact Drawers also causes the system to spaz out when an item is added to a drawer. This can be ignored if you use the drawer controller instead of the drawer itself when using the External Storage. Pack version 1.1.6, will get mod versions if this helps.

@raoulvdberge
Copy link
Collaborator

Yes, we know the issue is still present, that's why the bug is still open.

@refinedmods refinedmods locked and limited conversation to collaborators Jul 22, 2021
@raoulvdberge raoulvdberge changed the title [1.15.2] Can't remove items from RS grid when connected to DimStorage chest Can't remove items from RS grid Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants