Hide comments in fewer clicks #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I thought of making the secondary dropdown because I thought the Hide button would still appear outside the menu sometimes... but I can't find that anymore. If the Hide button is always inside the dropdown, I can shorten the code by just replacing the content of the dropdown on click instead of opening a new one. |
|
|
yakov116
reviewed
Jul 20, 2018
source/content.js
Outdated
| @@ -79,6 +79,7 @@ import displayIssueSuggestions from './features/display-issue-suggestions'; | |||
| import addPullRequestHotkey from './features/add-pull-request-hotkey'; | |||
| import openSelectionInNewTab from './features/add-selection-in-new-tab'; | |||
| import showFollowersYouKnow from './features/show-followers-you-know'; | |||
| import hideCommentsFaster from './features/hide-comments-faster'; | |||
There was a problem hiding this comment.
It may just be me. But quicklyhidecomments would sound a bit better.
fregante
changed the title
|
Should be good to go ⬇️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 5 clicks + 700px mouse movement to 3 clicks + 100px movement.
Fixes #1268
Replaces and closes #1410
Load more...(tested on Implement Sideways Data Loading facebook/react#3398)works when the hide button is always visible (not in a dropdown)(I haven't seen this one)