src: remove finalized_ member from Hash class

This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: nodejs#24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
refack · Jan 10, 2019 · 4bfc289 · 4bfc289
1 parent a784bad
commit 4bfc289
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3458,7 +3458,6 @@ bool Hash::HashInit(const char* hash_type) {
     mdctx_.reset();
     return false;
   }
-  finalized_ = false;
   return true;
 }
 
@@ -3512,7 +3511,6 @@ void Hash::HashDigest(const FunctionCallbackInfo<Value>& args) {
   unsigned int md_len;
 
   EVP_DigestFinal_ex(hash->mdctx_.get(), md_value, &md_len);
-  hash->finalized_ = true;
 
   Local<Value> error;
   MaybeLocal<Value> rc =

diff --git a/src/node_crypto.h b/src/node_crypto.h
@@ -476,14 +476,12 @@ class Hash : public BaseObject {
 
   Hash(Environment* env, v8::Local<v8::Object> wrap)
       : BaseObject(env, wrap),
-        mdctx_(nullptr),
-        finalized_(false) {
+        mdctx_(nullptr) {
     MakeWeak();
   }
 
  private:
   EVPMDPointer mdctx_;
-  bool finalized_;
 };
 
 class SignBase : public BaseObject {