Add current date/time template variables. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay in taking a look... the concept looks good to me... could you add an integration test for this behavior so we can make sure it stays working. Let me know if have question on adding a test. |
|
I have some test cleanup changes as well, but I'll save that for a separate pull request unless you'd prefer I include it now. |
|
If it’s unrelated, a separate one is fine... currently the tests are not succeeding on the CI so I need to figure that out as well.
…> On Dec 9, 2019, at 2:56 PM, Kurt Hardin ***@***.***> wrote:
I have some test cleanup changes as well, but I'll save that for a separate pull request unless you'd prefer I include it now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Ok, I'll open a separate request for those changes then since they are unrelated. BTW, the CI error appears to be related to specifying a fairly old version of rvm in |
|
Unfortunately that is just the beginning of the issues - the vscode extension test example seems to have changed a bit so working through that. I can manually get this PR through for now though.
… On Dec 9, 2019, at 3:16 PM, Kurt Hardin ***@***.***> wrote:
Ok, I'll open a separate request for those changes then since they are unrelated.
BTW, the CI error appears to be related to specifying a fairly old version of rvm in .travis.yml.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Got the extension test running on the CI again, can you resolve the conflicts and then I will merge in and release a new version. Thanks! |
Generated by 🚫 Danger |
reesemclean
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple support for inserting current date/time components into templates by variable substitution.