Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extension traits as per rust-lang/rfcs#445 #2

Merged
merged 1 commit into from
Mar 24, 2015
Merged

Rename extension traits as per rust-lang/rfcs#445 #2

merged 1 commit into from
Mar 24, 2015

Conversation

lambda-fairy
Copy link
Contributor

Quoth RFC 445:

For true extension traits, there should be a clear type or trait that they are extending. The extension trait should be called FooExt where Foo is that type or trait.

In some cases, the extension trait only applies conditionally. For example, AdditiveIterator is an extension trait currently in std that applies to iterators over numeric types. These extension traits should follow a similar convention, putting together the type/trait name and the qualifications, together with the Ext suffix: IteratorAddExt.

This patch renames the extension traits to match this convention.

@reem
Copy link
Owner

reem commented Mar 24, 2015

Awesome!

reem added a commit that referenced this pull request Mar 24, 2015
@reem reem merged commit 16ac788 into reem:master Mar 24, 2015
@reem
Copy link
Owner

reem commented Mar 24, 2015

Updated crates.io as well.

@lambda-fairy
Copy link
Contributor Author

That was quick, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants