Trimmed buffer comments & typo fixes #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucapette
force-pushed
the
typos
branch
2 times, most recently
from
2b7726b to
09a78e8
Compare
|
Thanks a lot for these ! Let me propose you that I leave this open for now, and until the other issue you raised is closed. Seems to me that it will allow to gather as much as possible in a single shot. Thanks again, don't hesitate to ping me if you need anything. |
|
Hello @lucapette , So after evaluating all alternatives, I've decided to maintain the legacy C GNU readline behavior, which is to return the raw, untrimmed buffer. Lexing it for comment removal is in fact out of the library's scope. Merged your changes in #58 ! Thanks a lot for the typos and the work ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started reading the code and come across little things like these