chore: Upgrade ESLint from v7 to v8 #3725

nzdjb · 2021-11-13T02:39:59Z

Work remaining:

upgrade eslint-plugin-react (once released)
~~upgrade eslint-plugin-prettier (once released)~~
~~upgrade eslint-plugin-jest-dom (once released)~~
upgrade eslint-plugin-jsx-a11y (once released)
resolve any linting issues surfaced by new versions

Release Notes

nzdjb · 2021-11-13T03:44:43Z

I initially thought eslint-plugin-prettier and eslint-plugin-jest-dom needed updates, but after the updates to the others, the issues from these seem to have been resolved.

nzdjb · 2021-11-13T04:02:00Z

New issues that appear under ESLint 8 that weren't there with ESLint 7:

/workspaces/redwood/packages/forms/src/index.tsx
  479:7  warning  'name' is missing in props validation            react/prop-types
  480:7  warning  'id' is missing in props validation              react/prop-types
  482:7  warning  'errorClassName' is missing in props validation  react/prop-types
  483:7  warning  'errorStyle' is missing in props validation      react/prop-types
  487:7  warning  'validation' is missing in props validation      react/prop-types
  488:7  warning  'onBlur' is missing in props validation          react/prop-types
  489:7  warning  'onChange' is missing in props validation        react/prop-types
  528:7  warning  'name' is missing in props validation            react/prop-types
  529:7  warning  'id' is missing in props validation              react/prop-types
  531:7  warning  'errorClassName' is missing in props validation  react/prop-types
  532:7  warning  'errorStyle' is missing in props validation      react/prop-types
  536:7  warning  'validation' is missing in props validation      react/prop-types
  537:7  warning  'onBlur' is missing in props validation          react/prop-types
  538:7  warning  'onChange' is missing in props validation        react/prop-types
  577:7  warning  'name' is missing in props validation            react/prop-types
  578:7  warning  'id' is missing in props validation              react/prop-types
  580:7  warning  'errorClassName' is missing in props validation  react/prop-types
  581:7  warning  'errorStyle' is missing in props validation      react/prop-types
  585:7  warning  'validation' is missing in props validation      react/prop-types
  586:7  warning  'onBlur' is missing in props validation          react/prop-types
  587:7  warning  'onChange' is missing in props validation        react/prop-types
  696:7  warning  'name' is missing in props validation            react/prop-types
  697:7  warning  'id' is missing in props validation              react/prop-types
  699:7  warning  'errorClassName' is missing in props validation  react/prop-types
  700:7  warning  'errorStyle' is missing in props validation      react/prop-types
  704:7  warning  'validation' is missing in props validation      react/prop-types
  705:7  warning  'onBlur' is missing in props validation          react/prop-types
  706:7  warning  'onChange' is missing in props validation        react/prop-types

/workspaces/redwood/packages/internal/src/generate/graphqlSchema.ts
  48:25  error  Unsafe usage of optional chaining. If it short-circuits with 'undefined' the evaluation will throw TypeError  no-unsafe-optional-chaining

/workspaces/redwood/packages/router/src/links.tsx
   64:10  warning  'onClick' is missing in props validation  react/prop-types
  105:58  warning  'onClick' is missing in props validation  react/prop-types

✖ 31 problems (1 error, 30 warnings)

… is undefined.

nzdjb · 2021-11-13T06:33:23Z

Have now resolved all the new linting issues.

The changes in packages/forms/src/index.tsx could do with a careful look from someone familiar with the intention of the typing. It wasn't entirely clear what the reason was for 'type' was being omitted and that 'id' not being defined. However, linting and tests both pass.

The other changes should be straightforward.

dac09 · 2021-11-15T17:29:04Z

Requesting a HODL ✋ on this till we merge in the babel changes that are going in #3719 please!

thedavidprice · 2021-11-16T06:26:34Z

@nzdjb Fantastic work! I'll queue this up for review to include in the next release. Thank you.

Roger that @dac09 👍

thedavidprice · 2021-11-19T19:33:58Z

packages/forms/src/index.tsx

@@ -89,6 +89,7 @@ interface FieldProps<
    | HTMLInputElement = HTMLInputElement
 > {
  name: string
+  id?: string


@jtoar can you confirm this is correct?

jtoar · 2021-11-19T20:07:12Z

packages/internal/src/generate/graphqlSchema.ts

@@ -45,7 +45,7 @@ export const generateGraphQLSchema = async () => {
    // This tries to clean up the output of those errors.
    console.error(e)
    console.error(chalk.red('Error parsing SDLs or Schema'))
-    for (const error of e?.errors) {
+    for (const error of e.errors ?? []) {


jtoar

Hey @nzdjb thanks for not only tracking the changes it'd take for us to upgrade to ESLint v8, but then also upgrading us as well! 🚀

I'm good with merging this as is, just had one question about TS in forms. The TS I did in the forms package is definitely not great but I'm seeing one type hint (for type) now that I feel like shouldn't be there:

Before:

After:

I'd just like to know if you thought it was correct show type as a prop when we do nothing with it in TextAreaField, etc?

thedavidprice · 2021-11-19T21:28:14Z

Great work on this! I'm merging now. If there's need to make an adjustment based on @jtoar question above, we can handle in a follow-up PR.

Thanks, everyone. 🚀

nzdjb · 2021-11-20T00:36:54Z

I'd just like to know if you thought it was correct show type as a prop when we do nothing with it in TextAreaField, etc?

Probably not correct, no, but was the minimal change to resolve the issue. I'll take another bash at it and see what can be done about omitting it.

callingmedic911

@nzdjb Thanks for all the work here! 🔥 While I was working on router stuff I came across a TS error.

I've added my suggestion as a fix, have a look whenever you get the chance. Feel free to include it in your ongoing forms related PR.

packages/router/src/links.tsx

nzdjb · 2021-11-21T19:57:16Z

@nzdjb Thanks for all the work here! 🔥 While I was working on router stuff I came across a TS error.
...

I've added my suggestion as a fix, have a look whenever you get the chance. Feel free to include it in your ongoing forms related PR.

Whoops! Sorry about that! 😞

Have added your suggested changes to #3762.

thedavidprice · 2021-11-24T15:48:06Z

@nzdjb we have a monthly meetup for Redwood Contributors, and it would be a pleasure to add you to the group invite. (Read more about Redwood Contributors here.)

Could you send me a DM on the Redwood Forums? Or any other preferred way to connect?

https://community.redwoodjs.com/u/thedavid/

nzdjb added 3 commits November 13, 2021 02:12

chore(eslint-config): Bump eslint to 8 and jsx-a11y plugin to match.

346b5bf

chore(eslint-config): Missing bumps from previous commit.

c9bfe7e

chore(eslint-config): Bump react plugin to support eslint 8.

12f270f

redwoodjs-bot bot assigned thedavidprice Nov 13, 2021

redwoodjs-bot bot added the triage/processing label Nov 13, 2021

nzdjb added 5 commits November 13, 2021 04:26

style(router): Add types for onClick.

7f9439d

fix(internal): Resolve unsafe chaining by using empty array if errors…

d8ea420

… is undefined.

fix(router): Better typing for onClick on links.

a55300b

style: Remove field omission that was causing unclear typing.

aff0e92

style: Add missing id type.

bd2090d

nzdjb marked this pull request as ready for review November 13, 2021 06:33

nzdjb added 2 commits November 13, 2021 22:06

chore(es-config): Resolve constraints issue.

3ded8fd

chore(deps): Yarn dedupe.

dfaaab2

thedavidprice linked an issue Nov 16, 2021 that may be closed by this pull request

Upgrade ESLint from v7 to v8 #3623

Closed

thedavidprice self-requested a review November 16, 2021 06:26

thedavidprice added dependencies release:breaking This PR is a breaking change and removed triage/processing labels Nov 16, 2021

thedavidprice added this to the next-release-priority milestone Nov 16, 2021

thedavidprice added 3 commits November 19, 2021 11:23

update packages

6a7b8d5

Merge branch 'main' into pr/3725

37ec6cb

update yarn.lock

8d66b40

thedavidprice reviewed Nov 19, 2021

View reviewed changes

jtoar reviewed Nov 19, 2021

View reviewed changes

jtoar approved these changes Nov 19, 2021

View reviewed changes

Merge branch 'main' into main

e962067

thedavidprice merged commit 2d2d90c into redwoodjs:main Nov 19, 2021

redwoodjs-bot bot modified the milestones: next-release-priority, next-release Nov 19, 2021

nzdjb mentioned this pull request Nov 20, 2021

refactor(forms): Change typing to omit type property + Workaround for upstream react/prop-types lint rule #3762

Merged

thedavidprice modified the milestones: next-release, v0.39.0 Nov 20, 2021

callingmedic911 reviewed Nov 21, 2021

View reviewed changes

packages/router/src/links.tsx Show resolved Hide resolved

packages/router/src/links.tsx Show resolved Hide resolved

realStandal mentioned this pull request Jan 9, 2022

added exports to form-component props #4089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Upgrade ESLint from v7 to v8 #3725

chore: Upgrade ESLint from v7 to v8 #3725

nzdjb commented Nov 13, 2021 •

edited by thedavidprice

Loading

nzdjb commented Nov 13, 2021

nzdjb commented Nov 13, 2021

nzdjb commented Nov 13, 2021

dac09 commented Nov 15, 2021

thedavidprice commented Nov 16, 2021

thedavidprice Nov 19, 2021

jtoar Nov 19, 2021

jtoar left a comment

thedavidprice commented Nov 19, 2021

nzdjb commented Nov 20, 2021

callingmedic911 left a comment

nzdjb commented Nov 21, 2021 •

edited

Loading

thedavidprice commented Nov 24, 2021

chore: Upgrade ESLint from v7 to v8 #3725

chore: Upgrade ESLint from v7 to v8 #3725

Conversation

nzdjb commented Nov 13, 2021 • edited by thedavidprice Loading

Release Notes

nzdjb commented Nov 13, 2021

nzdjb commented Nov 13, 2021

nzdjb commented Nov 13, 2021

dac09 commented Nov 15, 2021

thedavidprice commented Nov 16, 2021

thedavidprice Nov 19, 2021

Choose a reason for hiding this comment

jtoar Nov 19, 2021

Choose a reason for hiding this comment

jtoar left a comment

Choose a reason for hiding this comment

thedavidprice commented Nov 19, 2021

nzdjb commented Nov 20, 2021

callingmedic911 left a comment

Choose a reason for hiding this comment

nzdjb commented Nov 21, 2021 • edited Loading

thedavidprice commented Nov 24, 2021

nzdjb commented Nov 13, 2021 •

edited by thedavidprice

Loading

nzdjb commented Nov 21, 2021 •

edited

Loading