Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing dbAuth): Add "yes" prompt testing for WebAuthn #10823

Merged
merged 4 commits into from
Jun 15, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 15, 2024

Make sure to test prompt answer "yes" and "no" for the WebAuthn prompt. This required pretty involved mocking of Listr2 that I hope we can reuse for other tests as well in the future

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Jun 15, 2024
@Tobbe Tobbe added this to the chore milestone Jun 15, 2024
@Tobbe Tobbe changed the title Tobbe g dbauth test prompt yes no chore(testing dbAuth): Add yes prompt testing for WebAuthn Jun 15, 2024
@Tobbe Tobbe changed the title chore(testing dbAuth): Add yes prompt testing for WebAuthn chore(testing dbAuth): Add "yes" prompt testing for WebAuthn Jun 15, 2024
@Tobbe Tobbe merged commit 8b40ed2 into redwoodjs:main Jun 15, 2024
51 checks passed
Josh-Walker-GM pushed a commit that referenced this pull request Jun 17, 2024
Make sure to test prompt answer "yes" and "no" for the WebAuthn prompt.
This required pretty involved mocking of Listr2 that I hope we can reuse
for other tests as well in the future
dac09 added a commit to dac09/redwood that referenced this pull request Jun 17, 2024
…ckage-cjsonly-new-build

* 'main' of github.com:redwoodjs/redwood: (66 commits)
  chore(testing dbAuth): Add "yes" prompt testing for WebAuthn (redwoodjs#10823)
  chore(testing dbAuth): Mock console.log to silence test output (redwoodjs#10821)
  chore(testing dbAuth): Remove duplicated tests (redwoodjs#10822)
  chore(testing dbAuth): Remove outdated code (redwoodjs#10820)
  chore(testing dbAuth): Consistent naming and fix blue squiggles (redwoodjs#10819)
  chore(testing dbAuth): provide mock implementations (redwoodjs#10818)
  feat(dbAuth): Only suggest dbAuth setup if needed (redwoodjs#10793)
  chore(dbAuth): Fix test for webauthn prompt in `g dbAuth` (redwoodjs#10814)
  fix(dbAuth): Print the correct "post message" after generation (redwoodjs#10813)
  fix(dbauth): Fix spacing issue in task titles (redwoodjs#10811)
  deps(docs): update braces package (redwoodjs#10809)
  chore(deps): bump braces from 3.0.2 to 3.0.3 in /tasks/check (redwoodjs#10808)
  chore(deps): update yarn to v4.3.0 (redwoodjs#10801)
  chore(deps): update dependency tsx to v4.15.2 (redwoodjs#10800)
  chore(deps): update dependency @clerk/types to v3.65.2 (redwoodjs#10795)
  chore(deps): update dependency firebase to v10.12.2 (redwoodjs#10802)
  chore(deps): update dependency rollup to v4.18.0 (redwoodjs#10799)
  chore(deps): update dependency jsdom to v24.1.0 (redwoodjs#10798)
  chore(deps): update dependency @types/vscode to v1.90.0 (redwoodjs#10796)
  chore(deps): update dependency @clerk/clerk-react to v4.32.2 (redwoodjs#10794)
  ...
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants