Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(filepath): Use node:url to convert to file path #10475

Merged
merged 4 commits into from
Apr 18, 2024
Merged

chore(filepath): Use node:url to convert to file path #10475

merged 4 commits into from
Apr 18, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 18, 2024 •
edited
Loading

Use pathToFileURL from node:url to import from absolute paths, as recommended here: nodejs/node#31710 (comment)

@Tobbe Tobbe added changesets-ok Override the changesets check and removed changesets-ok Override the changesets check labels Apr 18, 2024
@Tobbe Tobbe added this to the chore milestone Apr 18, 2024
@Tobbe Tobbe changed the title fix(filepath): Use node:url to convert to file path chore(filepath): Use node:url to convert to file path Apr 18, 2024
@Tobbe Tobbe added changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users) labels Apr 18, 2024
@Tobbe Tobbe modified the milestones: chore, SSR Apr 18, 2024
@Tobbe Tobbe merged commit aaffa18 into redwoodjs:main Apr 18, 2024
54 of 70 checks passed
@Tobbe Tobbe deleted the tobbe-ssr-fix-path-to-file-url branch April 18, 2024 13:46
@Josh-Walker-GM Josh-Walker-GM modified the milestones: SSR, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @Josh-Walker-GM