Fix: Add missing jsonDisplay function to formatters.tsx.template
#6902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jtoar
pushed a commit
that referenced
this pull request
Nov 23, 2022
…6902) * Added jsonDisplay to formatters * Update test snapshots * Added jsonDisplay test to formatters.test.tsx.template * Rebuilt test-project fixture * Fix missing import in formatters test template * Update test snapshot for jsonDisplay test * update fixtures to include import fix Co-authored-by: Tobbe Lundberg <[email protected]>
jtoar
pushed a commit
that referenced
this pull request
Nov 23, 2022
…6902) * Added jsonDisplay to formatters * Update test snapshots * Added jsonDisplay test to formatters.test.tsx.template * Rebuilt test-project fixture * Fix missing import in formatters test template * Update test snapshot for jsonDisplay test * update fixtures to include import fix Co-authored-by: Tobbe Lundberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #6900
Solution
Restore the
jsonDisplayfunction to the formatters template file.Question
@Tobbe Did you mean to remove this function all together in #6221 and don't want it added back now?
Notes
I was initially confused why we could have imports of this non-existing function within passing test snapshots (see link below) until I realised the test doesn't care if the snapshot file is valid JS just that it character for character matches.
https://github.com/redwoodjs/redwood/blob/fd8229c550864f11c8140b8f8cb43f8d609ebd52/packages/cli/src/commands/generate/scaffold/__tests__/__snapshots__/scaffold.test.js.snap#L641