Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minified check #4454

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Remove minified check #4454

merged 2 commits into from
Dec 17, 2022

Conversation

trajano
Copy link

@trajano trajano commented Dec 15, 2022

Fixes #4443

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3290f0:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@trajano
Copy link
Author

trajano commented Dec 16, 2022

@timdorr I saw you retry the job still failed though is it a npmjs issue?

@timdorr
Copy link
Member

timdorr commented Dec 17, 2022

Hmm, tried something and it didn't work. Oh well. I'll check it out locally and try to resolve. Probably a mix of old and yanked deps.

@timdorr timdorr merged commit cba4a0d into reduxjs:4.x Dec 17, 2022
jeanregisser referenced this pull request in valora-inc/wallet Feb 23, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [redux](http://redux.js.org)
([source](https://github.com/reduxjs/redux)) | [`^4.2.0` ->
`^4.2.1`](https://renovatebot.com/diffs/npm/redux/4.2.0/4.2.1) |
[![age](https://badges.renovateapi.com/packages/npm/redux/4.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/redux/4.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/redux/4.2.1/compatibility-slim/4.2.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/redux/4.2.1/confidence-slim/4.2.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>reduxjs/redux</summary>

### [`v4.2.1`](https://github.com/reduxjs/redux/releases/tag/v4.2.1)

[Compare
Source](https://github.com/reduxjs/redux/compare/v4.2.0...v4.2.1)

This bugfix release removes the `isMinified` internal check to fix a
compat issue with Expo. That check has added [in early 2016, soon after
Redux 3.0 was released](https://github.com/reduxjs/redux/issues/1029),
at a time when it was still less common to use bundlers with proper
production build settings. Today that check is irrelevant, so we've
removed it.

#### What's Changed

- Remove minified check by
[@&#8203;trajano](https://github.com/trajano) in
[https://github.com/reduxjs/redux/pull/4454](https://github.com/reduxjs/redux/pull/4454)

**Full Changelog**:
reduxjs/redux@v4.2.0...v4.2.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants