Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended API to ForkedTaskApi #4363

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkirby
Copy link

@kkirby kkirby commented Apr 22, 2024

This PR aims to fix #3314.

This is currently a draft as I have yet to fully update all TypeScript types and add tests.

I'm creating this to get any feedback.

Copy link

codesandbox bot commented Apr 22, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 6bfbf34
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/662697e6927cfb0008c82e82
😎 Deploy Preview https://deploy-preview-4363--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson
Copy link
Collaborator

Ah, nice, thank you!

Out of curiosity, what prompted the move of createFork in the file?

@kkirby
Copy link
Author

kkirby commented Apr 22, 2024

what prompted the move of createFork in the file?

I actually didn't. I moved createTakePattern before createFork since the updated createFork depends on createTakePattern. I'll split up the code into more commits to make that more evident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend ForkedTaskApi to include API
2 participants