Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all files #369

Merged
merged 8 commits into from
Aug 17, 2024
Merged

Format all files #369

merged 8 commits into from
Aug 17, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Bumps Prettier to latest version.
  • Formats all files.

Copy link

codesandbox-ci bot commented Mar 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@timdorr
Copy link
Member

timdorr commented Mar 22, 2024

Can you leave the .yarn/releases folder out of these PRs? Those should remain untouched as an artifact stored in the project.

@aryaemami59
Copy link
Contributor Author

@timdorr sure.

Add `.gitattributes` file to make line endings more consistent (reduxjs#363)

Fix webpack 4 support by setting `target: es2017` for `redux.legacy-esm.js` (reduxjs#370)

Revert "Run Prettier on all files"

This reverts commit 39e8094.

Run Prettier on all files

Add `.gitattributes` file to make line endings more consistent (reduxjs#363)
@@ -2,6 +2,5 @@
"semi": false,
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "none",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the vast majority of changes are related to this config change. What's the motivation? Just asking in case we can keep this to a less extensive set of changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staying consistent with the other repos. Since the plan was to eventually unify all their configs by having them use the shareable configs created in reduxjs/redux-toolkit#4138, I thought taking care of line endings/formatting issues in one PR would make things less unpredictable so you guys won't have to deal with a bunch of formatting changes in an unrelated PR in case somebody decides to run Prettier before pushing their changes.

@timdorr
Copy link
Member

timdorr commented Aug 17, 2024

Alrighty, let's merge this in. Thanks!

@timdorr timdorr merged commit 8ab85c9 into reduxjs:master Aug 17, 2024
21 checks passed
@aryaemami59 aryaemami59 deleted the format-all-files branch August 19, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants