Allow action to be typed with any

[laat]

By swapping the order of the calls, the Action param can be any. From #213 (comment)

[timdorr]

Thanks!

[zqran]

I found that when writing code in VSCode, there is no clear type hint. Is it related to this?

The demo is as follows:
https://codesandbox.io/s/redux-thunk-ts-7ygmv?file=/src/index.ts

[laat]

It's not related, there has been lots of changes since this commit.

I cannot reproduce your issue, however I get a ReferenceError: type is not defined, because the type variable is not defined.

[zqran]

When you type the code, there will be no type hint for the type attribute

When I try to exchange the overload order, it will be prompted：

ThunkDispatch：Original type from redux-thunk v2.4.0：（no type hint）

export interface ThunkDispatch<State, ExtraThunkArg, BasicAction extends Action> extends Dispatch<BasicAction> {
    /** Accepts a thunk function, runs it, and returns whatever the thunk itself returns */
    <ReturnType>(thunkAction: ThunkAction<ReturnType, State, ExtraThunkArg, BasicAction>): ReturnType;
    /** A union of the other two overloads. This overload exists to work around a problem
     *  with TS inference ( see https://github.com/microsoft/TypeScript/issues/14107 )
     */
    <ReturnType, Action extends BasicAction>(action: Action | ThunkAction<ReturnType, State, ExtraThunkArg, BasicAction>): Action | ReturnType;
}

Swapping the order of the calls：（type hint）

export interface ThunkDispatch<State, ExtraThunkArg, BasicAction extends Action> extends Dispatch<BasicAction> {
    /** A union of the other two overloads. This overload exists to work around a problem
     *  with TS inference ( see https://github.com/microsoft/TypeScript/issues/14107 )
     */
    <ReturnType, Action extends BasicAction>(action: Action | ThunkAction<ReturnType, State, ExtraThunkArg, BasicAction>): Action | ReturnType;

    /** Accepts a thunk function, runs it, and returns whatever the thunk itself returns */
    <ReturnType>(thunkAction: ThunkAction<ReturnType, State, ExtraThunkArg, BasicAction>): ReturnType;
}

[markerikson]

@zqran Please file a separate issue to discuss this - it sounds like a worthwhile topic, but it's unrelated to this issue.