fixes React.PropTypes deprecation in React#665
Closed
srinathh wants to merge 1 commit into
Closed
Conversation
Member
|
Superceded by #663 |
Author
|
Ah ok. Didn't see the other PR had preceeded by a few hours :-)
…On Apr 9, 2017 10:16, "Tim Dorr" ***@***.***> wrote:
Superceded by #663 <#663>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#665 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC1hFZDiaCB18uWSKYruOrosASuorohJks5ruGKhgaJpZM4M3yEI>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially fixes deprecation issues related to PropTypes that causes warnings to pop up when using react-redux with version 15.5 of React. This passes tests.
In the react-redux test setups, there are still issues with createClass and TestUtils that need to be fixed but I haven't been able to understand the test structuring well enough to fix them.
Fixes #664