Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect refactor to use transactional setState() #373

Closed
wants to merge 8 commits into from
Closed

Connect refactor to use transactional setState() #373

wants to merge 8 commits into from

Commits on Apr 30, 2016

  1. make computeStateProps and computeDispatchProps simpler

    @slorber
    slorber committed Apr 30, 2016
    Configuration menu
    Copy the full SHA
    ab1c422 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2016

  1. Almost-working refactor of connect. Just 1 test not passing: the hard… 

    … one :'(
    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    e9a874f View commit details
    Browse the repository at this point in the history

  2. Make all tests pass for big coonect refactoring! reduxjs#368

    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    778730f View commit details
    Browse the repository at this point in the history

  3. Simplify code, remove useless console.log, make linter pass, for redu… 

    …xjs#368
    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    bcffa66 View commit details
    Browse the repository at this point in the history

  4. Simplify reinjection fo errors inside render

    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    d372b6e View commit details
    Browse the repository at this point in the history

  5. comment typo

    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    ea6955d View commit details
    Browse the repository at this point in the history

  6. Revert change in test that was not needed

    @slorber
    slorber committed May 1, 2016
    Configuration menu
    Copy the full SHA
    79e44b0 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2016

  1. Do not subscribe to store updates before componentDidMount, so that n… 

    …o subscription is done server-side
    @slorber
    slorber committed May 2, 2016
    Configuration menu
    Copy the full SHA
    0a8744d View commit details
    Browse the repository at this point in the history