remove options parameter

[phapdinh]

I checked the use of the wrapMapToPropsConstant function in the codebase and it is only used in wrapMapToProps and mapDispatchToProps. All three places, the function passed in doesn't take in a second parameter. This might be left over code from a previous refactor or maybe left over for some future feature that wants to pass options as a parameter into the function. However, I thought I bring it up to your attention.

[netlify]

Deploy preview for react-redux-docs ready!

Built with commit 38dae32

https://deploy-preview-1528--react-redux-docs.netlify.com

[timdorr]

Nope, it's passed right here:

react-redux/src/connect/selectorFactory.js

Lines 104 to 106 in 5e0c50d

	const mapStateToProps = initMapStateToProps(dispatch, options)
	const mapDispatchToProps = initMapDispatchToProps(dispatch, options)
	const mergeProps = initMergeProps(dispatch, options)

[phapdinh]

@timdorr options is passed into the initMapDispatchToProps function, but the getConstant function doesn't use it. So your passing in an option parameter that is not being used in the codebase. I can update the PR to remove the options from the initMapDispatchToProps. However, the options is not being used by the nested function. This would be more apparent in typescript, but right now javascript doesn't throw an error if you pass in unnecessary parameters

[timdorr]

Well, the long term plan is to drop connectAdvanced (#1236) and refactor all of these complex factory functions into something much simpler. So, this will go away one way or another. Thanks for bringing it up!