Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect() API doc #1140

Merged
merged 15 commits into from
Dec 23, 2018
Merged

Add connect() API doc #1140

merged 15 commits into from
Dec 23, 2018

Conversation

wgao19
Copy link
Contributor

@wgao19 wgao19 commented Dec 20, 2018

What does this PR do?

New doc piece regarding #1001: connect() API

Summary of the Changes

  • Add connect() docs
  • Doc site changes
  • Move remaining content of api.md to createProvider() and connectAdvanced(), respectively

Addresses #1132, #1119.

@netlify
Copy link

netlify bot commented Dec 20, 2018

Deploy preview for react-redux-docs ready!

Built with commit 6ca59ce

https://deploy-preview-1140--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Dec 20, 2018

I fixed those merge conflicts for you. I think this looks good! Any objections, @markerikson?

@markerikson
Copy link
Contributor

Gimme a chance to do one more look-over today or tomorrow.

@markerikson
Copy link
Contributor

Looking at this now.

I think I want to focus on just v6 for the moment, and then work backwards to come up with separate docs for v5.

Working on some edits.

@markerikson markerikson merged commit 5088345 into reduxjs:master Dec 23, 2018
@markerikson
Copy link
Contributor

Aaaand merged!

Did cleanup on connect and connectAdvanced, removed the createProvider page, and went ahead and ran the docs pages through Prettier.

albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* Add `connect()` doc

* Move remaining api.md to `createProvider()` and `connectAdvanced()` docs, repectively

* Hide duplicated title for Provider.md

* Update doc site configurations for connect doc

* Fix `siteConfig.js`

* Fix some links.

* More betterer link fix...

* Clean up connect docs

* Remove createProvider page

* Clean up connectAdvanced

* Include docs in formatting

* Specify format spacing

* Format docs content

* Remove stray semi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants