Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1031 Set up basic docusaurus structure #1032

Merged
merged 4 commits into from
Oct 6, 2018

Conversation

sveinpg
Copy link
Contributor

@sveinpg sveinpg commented Oct 5, 2018

#1031. Initial setup of docusaurus in a separate folder (/docusaurus).

To run locally or publish you first have to change folders to /docusaurus/website

Run locally: npm install && npm start
This should open the docusaurus on localhost:3000

To publish to netlify: https://docusaurus.io/docs/en/publishing#hosting-on-netlify

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 5, 2018

@markerikson Seems like some checks were not successful? Do you mind pointing me in the right direction?

@markerikson
Copy link
Contributor

markerikson commented Oct 6, 2018

Looks like the Netlify integration I turned on this afternoon added a whole bunch of additional checks. Most of those checks are failing because it's not publishing the output to the folder I'd specified in Netlify, which was /docs-build. We'd need to either change the Netlify settings, or change the Docusaurus config.

Out of curiosity what's the Dockerfile for in this setup? How does that fit in?

I'd also prefer to keep our content in /docs just so we're not moving things around.


// Used for publishing and more
projectName: "react-redux",
organizationName: "facebook",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not Facebook :) We're the reduxjs org.

const siteConfig = {
title: "React Redux", // Title for your website.
tagline: "React Redux Documentation",
url: "https://your-docusaurus-test-site.com", // Your website URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should hopefully be https://react-redux.js.org shortly.


/* Colors for website */
colors: {
primaryColor: "#20232a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like these are shades of blue? Let's try to go with Redux's purple and white, or something like that.

@markerikson
Copy link
Contributor

Now that I look at this, is there a reason to actually have this in a /docusaurus subfolder? Babel's setup doesn't do that - it's just $REPO/website ( https://github.com/babel/website ).

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 6, 2018

Babel's setup is a new repo for the docusaurus website and docs.

Personally I prefer if the docs is in the repo itself. However, babel is a special case since it consists of multiple repos.

We could move the website folder to the root of this repo?

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 6, 2018

The dockerfile was generated when I ran the setup, we don't need it.

@markerikson
Copy link
Contributor

Okay, let's give this a shot. Can always revert it if things seem weird.

I'll merge it now. I'll be busy this afternoon, but will try working on some of the setup for it tonight.

@markerikson markerikson merged commit 9cbdc69 into reduxjs:master Oct 6, 2018
@markerikson
Copy link
Contributor

markerikson commented Oct 6, 2018

Okay, this is pretty cool! I just pulled master locally, installed website deps, and ran the local server, and it works!

We'll want to see how to get better syntax highlighting for the snippets, and also play around with how to get CodeSandbox embeds working, but this is a great start!

Now, let me see about how to get this hooked up to Netlify...

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 6, 2018

Great! Let me know if I can contribute on anything else.

@markerikson
Copy link
Contributor

Tell you what. Can you go and investigate how Babel and React have a bot set up to do preview deploys of PRs?

@markerikson
Copy link
Contributor

WOOHOO! We are LIVE!!!

https://react-redux-docs.netlify.com/

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 6, 2018

Sure. I'll take a look at it tomorrow

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 6, 2018

@markerikson Seems like you can enable branch deploys to get the desired behaviour as described here: https://www.netlify.com/docs/continuous-deployment/#branches-deploys

@markerikson
Copy link
Contributor

Okay, I think I just turned it on. Now, I see the deploy preview "check" for #1033 , but it's kinda buried in the "checks" section. Perhaps the bots are needed to add a comment pointing to that for visibility?

@sveinpg
Copy link
Contributor Author

sveinpg commented Oct 7, 2018

There is a section om how to configure it called "github pull request comments"

https://www.netlify.com/docs/webhooks/#outgoing-webhooks

@markerikson
Copy link
Contributor

Yep, got that figured out and turned on!

albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* reduxjs#1031 Set up basic docusaurus structure

* Removed docker related files

* Added metadata to the doc files

* Code review: Moved docusaurus website to the top level of the repo and updated values in siteConfig.js according to comments by @markerikson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants