Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps deprecation notice #4023

Closed
kprovance opened this issue Sep 13, 2024 · 4 comments
Closed

Google Maps deprecation notice #4023

kprovance opened this issue Sep 13, 2024 · 4 comments

Comments

@kprovance
Copy link
Member

Saw this notice in the console today while testing:

As of February 21st, 2024, google.maps.Marker is deprecated. Please use google.maps.marker.AdvancedMarkerElement instead. At this time, google.maps.Marker is not scheduled to be discontinued, but google.maps.marker.AdvancedMarkerElement is recommended over google.maps.Marker. While google.maps.Marker will continue to receive bug fixes for any major regressions, existing bugs in google.maps.Marker will not be addressed. At least 12 months notice will be given before support is discontinued. Please see https://developers.google.com/maps/deprecations for additional details and https://developers.google.com/maps/documentation/javascript/advanced-markers/migration for the migration guide.)

Might want to update that.

@kprovance
Copy link
Member Author

Needs testing on a live server since Google restricts Map JS on local installs.

@kprovance
Copy link
Member Author

So, the 'places' API that makes the autocomplete work isn't working on a live site either. I don't think it's the code, as it basically follows the posted example. It may be in the way the APIs are set. I don't know. I need to research.

@kprovance
Copy link
Member Author

The short version is Google is deprecating their Maps, Places, and Marker libraries. New versions and legacy versions just won't play well together and one thing or another breaks after fixing another.

The solution seems to be to rewrite the JavaScript with code for the new versions and dump the legacy stuff. It'll have to happen eventually, anyway. My plan is to take the sample code Google provides and adapt it to the extension and that should be that!

@kprovance
Copy link
Member Author

And that should be that, at least, unless Google deprecates something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant