Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typings #45

Merged
merged 14 commits into from
Jan 24, 2017
Merged

Improve typings #45

merged 14 commits into from
Jan 24, 2017

Commits on Dec 11, 2016

  1. Add type guard, generic, and test

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    5eb7a9c View commit details
    Browse the repository at this point in the history

  2. Improve generic naming

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    9d1c497 View commit details
    Browse the repository at this point in the history

  3. Add ErrorFSA alias

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    ce57e63 View commit details
    Browse the repository at this point in the history

  4. Write test correctly to avoid confusion

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    644622e View commit details
    Browse the repository at this point in the history

  5. Add someField validation

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    80a71fa View commit details
    Browse the repository at this point in the history

  6. Add somefield test

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    2a6b80a View commit details
    Browse the repository at this point in the history

  7. Add semi-colon, move tsc to posttest

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    8c64c1b View commit details
    Browse the repository at this point in the history

  8. Add 3 more semi-colon

    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    ee78552 View commit details
    Browse the repository at this point in the history

  9. Remove optional designation. 

    Since `payload` and `meta` is generic, user can specify `void` or `undefined` to indicate it does not present.

Removing the optional designation improves type guard.

see `isCustomAction4()` for example
    @unional
    unional committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    c9fa687 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Fix more linting issue

    @unional
    unional committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    5216925 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2017

  1. Merge remote-tracking branch 'acdlite/master'

    @unional
    unional committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    3df9bea View commit details
    Browse the repository at this point in the history

  2. Adding eslint for typescript. Update yarn.lock

    @unional
    unional committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    b9d81be View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2017

  1. Change typescript-eslint-parser to devDeps

    @unional
    unional committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    73529c4 View commit details
    Browse the repository at this point in the history

  2. Move eslint-plugin-typescirpt to devDeps also.

    @unional
    unional committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    4157c98 View commit details
    Browse the repository at this point in the history