Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability To Record #468

Open
wants to merge 2 commits into
base: typescript
Choose a base branch
from
Open

Conversation

XPZ2k15
Copy link

@XPZ2k15 XPZ2k15 commented Jul 29, 2024

[Hotkeys (in action-screenshot) ]
image

Modified Screenshot to also handle recording:

image

Added Icon for Gamebar

image
image

image
image
image

@XPZ2k15
Copy link
Author

XPZ2k15 commented Jul 29, 2024

This feature can definitely be polished and even add another buffer for the blobs and do a "Replay Buffer". Utilize existing code, but instead of recording 1 minute ahead add another feature for a preference of "Replays" and "Replay Length" Then have it always CAPTURE/RECORD this replay as a rotating buffer. [Would be good for the next step of this feature and maybe separating into it's own ts instead of screenshot]

@XPZ2k15
Copy link
Author

XPZ2k15 commented Jul 29, 2024

One more note, I was unable to get AUDIO working for recordings UNLESS i checked the "Combine Audio/Video Streams" if you can fix this or have an idea. Greatly Appreciated.

@redphx
Copy link
Owner

redphx commented Jul 29, 2024

Thank you. I'm busy with updating the Android app at the moment so don't expect me to check on this MR right away.

One more note, I was unable to get AUDIO working for recordings UNLESS i checked the "Combine Audio/Video Streams" if you can fix this or have an idea. Greatly Appreciated.

Yes this is expected. And I think this recording feature doesn't work with voice chat? Also the Android app needs to be updated to support this feature.

Thanks again.

@Danfun64
Copy link

Any chance of recording for longer than a minute?

@XPZ2k15
Copy link
Author

XPZ2k15 commented Aug 22, 2024

@Danfun64

I was testing this feature and I never tried to integrated another box in the settings area to control this as a variable from the UI. Though I can probably figure it out, you would have to wait a little while. I am also integrating a replay buffer.

This means Instead of recording X time forward. You can also Record X Time back and click the hotkey to capture it.

Example: Playing a shooter game and you had a nice play. You weren't recording, but your replay system is on, you can click the hotkey and capture the last X time.

If you are feeling impatient, just change the time from 1 minute to whatever you like manually through the script in tamper monkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants