-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic Korean support #849
Conversation
👍 |
@raccoonyy Thank you very much for the valuable contributeion! I will look into the changes. |
@takahi-i Is there anything I can help? |
Deeply sorry for the late response... I will review this PR this weekend. |
Thanks! 👍 |
I looked into the changes and confirmed the changes are great! Before the merge, is it possible to add the sample documents in several formats (such as markdown or asciidoc) 🙏 ? The following is the directory of the samples, just we add the files (under https://github.com/redpen-cc/redpen/tree/master/redpen-cli/sample/sample-doc |
I will add the docs soon. Thanks. :) |
@takahi-i I added sample documents. I'm really sorry for the late. |
* Add KOMORAN to pom.xml(korean morphological analyzer) * Implement basic korean tokenizer
Thank you very much @raccoonyy ! I will look into the changes this weekend. |
LGTM. Can you grant these changes under the Apache License 2.0 @raccoonyy? |
@takahi-i Yes I do. :) Do I have to modify the docs to grant Apache License 2.0? |
Thank you for the agreement @raccoonyy!
Nothing. We just confirm it when large feature is proposed. Thank you very much for the consistent work! |
Hello. I implemented basic Korean support for proofreading Korean. I referred to #568 and added Korean morphological analyzer Komoran as a dependency.
This P.R. based on @nacyot's #784 .