Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to JUnit5 #797

Merged
merged 4 commits into from
Sep 25, 2017
Merged

migrate to JUnit5 #797

merged 4 commits into from
Sep 25, 2017

Conversation

yusuke
Copy link
Contributor

@yusuke yusuke commented Sep 23, 2017

fixes #795

@yusuke
migrating redpen-server to JUnit5
1eb9d5e 
assumeNoException(String, Exception) is not existing in JUnit5. use assumeNoException(Exception) instead
@yusuke
migrating redpen-plugin to JUnit5
62f4ed7
@yusuke
migrating redpen-cli and redpen-core to JUnit5
334a95d 
make test classes and test methods package private
@yusuke yusuke requested a review from takahi-i September 23, 2017 15:34
@yusuke yusuke self-assigned this Sep 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.008% when pulling b90ef5b on junit5-795 into 868c0d8 on master.

@takahi-i
Copy link
Member

Hi @yusuke, thank you very much for the valuable contribution as always! LTGM 🎉

@yusuke yusuke merged commit 92b1c4a into master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahi-i takahi-i takahi-i approved these changes

Assignees

@yusuke yusuke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply JUnit5
3 participants
@yusuke @coveralls @takahi-i