Overriding executable rpath with patchelf
#25059
Open
+84
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
force-pushed
the
bazel-patchelf
branch
2 times, most recently
from
b9c472a to
4152c60
Compare
Signed-off-by: Michał Maślanka <[email protected]>
By overriding an `executable` rpath we no longer need to care about setting correct `LB_LIBRARY_PATH` Signed-off-by: Michał Maślanka <[email protected]>
Signed-off-by: Michał Maślanka <[email protected]>
Signed-off-by: Michał Maślanka <[email protected]>
mmaslankaprv
force-pushed
the
bazel-patchelf
branch
from
4152c60 to
2a5da25
Compare
rockwotj
approved these changes
Feb 7, 2025
| inputs = [original_binary], | ||
| outputs = [patched_binary], | ||
| executable = ctx.executable._patchelf, | ||
| arguments = ["--force-rpath", "--set-rpath", path_override, original_binary.path, "--output", patched_binary.path], |
There was a problem hiding this comment.
Why are we setting --force-rpath? https://man.archlinux.org/man/patchelf.1.en#force-rpath
| @@ -17,7 +17,6 @@ go_binary( | |||
| visibility = ["//bazel/packaging:__pkg__"], | |||
| x_defs = { | |||
| "binaryPath": "/opt/redpanda/libexec/redpanda", | |||
| "ldLibraryPath": "/opt/redpanda/lib", | |||
There was a problem hiding this comment.
Do we even need these anymore with this approach? Should we remove the wrappers and just put the real binaries in bin/ instead of libexec/?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding Redpanda executable makes it easier to handle shared library loading.
Backports Required
Release Notes