archival: Handle nested shutdown errors #24927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested exceptions are treated as shutdown errors only if both inner and outer exceptions are shutdown errors. But sometimes the connections are closed during the shutdown and the disconnect error is triggered. In this case the exception is reported as true error. This increases the noise level and complicates log monitoring. This commit changes nested exception handling. If one of the exceptions is a shutdown error and another one is a disconnect exception (broken pipe) the error is treated as a shutdown error. Signed-off-by: Evgeny Lazin <[email protected]>
StephanDollberg
approved these changes
Jan 24, 2025
CI test resultstest results on build#61164
|
|
/backport v24.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested exceptions are treated as shutdown errors only if both inner and outer exceptions are shutdown errors. But sometimes the connections are closed during the shutdown and the disconnect error is triggered. In this case the exception is reported as true error. This increases the noise level and complicates log monitoring.
This commit changes nested exception handling. If one of the exceptions is a shutdown error and another one is a disconnect exception (broken pipe) the error is treated as a shutdown error.
Backports Required
Release Notes