Export number of members and assigned partitions for each topic in a consumer group #106
+110
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
commented
Aug 1, 2021
amuraru
force-pushed
the
issue-104
branch
7 times, most recently
from
46f428c
to
37283c5
Compare
weeco
reviewed
Aug 2, 2021
Comment on lines
90
to
91
| // number of members with no assignment in a stable consumer group | ||
| if membersWithEmptyAssignment > 0 && group.State == "Stable" { |
There was a problem hiding this comment.
I'm wondering whether we actually want that condition again (or just report it as zero everytime where this is case - regardless of the current group state). I assume that you have a certain usecase in mind which is why you added these metrics in the first place. Do you care to explain them so that I can understand the idea?
There was a problem hiding this comment.
Right - superseded by #108
amuraru
force-pushed
the
issue-104
branch
2 times, most recently
from
89de365
to
249d16b
Compare
|
@weeco kind reminder to review this PR. thanks :) |
weeco
reviewed
Sep 1, 2021
|
thanks for the review @weeco - would you please check the last version? |
…consumer group Added consumer_group_empty_members, consumer_group_topic_members and consumer_group_topic_assigned_partitions metrics. Fixes redpanda-data#104
weeco
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added consumer_group_topic_members, consumer_group_topic_assigned_partitions and consumer_group_empty_members metrics.
Fixes #104