Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iceberg properties #846

Merged
merged 4 commits into from
Dec 2, 2024
Merged

add iceberg properties #846

merged 4 commits into from
Dec 2, 2024

Conversation

Deflaimun
Copy link
Contributor

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Deflaimun Deflaimun requested a review from a team as a code owner November 11, 2024 15:22
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 9aaff69
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6748c2ef809b080008f146dc
😎 Deploy Preview https://deploy-preview-846--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun force-pushed the iceberg-properties branch 4 times, most recently from faa37aa to b379b52 Compare November 11, 2024 15:24
@Deflaimun Deflaimun changed the title add iceberg and tomstone properties add iceberg properties Nov 11, 2024
@@ -1520,6 +1520,52 @@ A list of supported HTTP authentication mechanisms.

---

=== iceberg_catalog_base_location

Base path for the cloud object storage-backed Iceberg catalog. After Iceberg is enabled, do not change this value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deflaimun can we find out if we mean to say both "cloud" and "object"..? I think @andrwng might be able to help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrwng on docs we usually side with object storage. Can I make this change here ?

@@ -1534,6 +1580,96 @@ Enables the translation of topic data into Iceberg tables. Setting `iceberg_enab

---

=== iceberg_rest_catalog_endpoint

URL of Iceberg REST catalog endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrwng is this meant to be set together with / as a pair with iceberg_catalog_base_location?

@Deflaimun Deflaimun requested a review from kbatuigas November 28, 2024 18:49
@Deflaimun Deflaimun merged commit 1232e88 into v-WIP/24.3 Dec 2, 2024
7 checks passed
@Deflaimun Deflaimun deleted the iceberg-properties branch December 2, 2024 15:41
Deflaimun added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants