-
Notifications
You must be signed in to change notification settings - Fork 48
Lowercase field names required for Glue #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowercase field names required for Glue #1387
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds new guidance and examples to the Iceberg AWS Glue documentation (modules/manage/pages/iceberg/iceberg-topics-aws-glue.adoc): a limitation requiring lowercase field names; expanded notes on nested partition specs and default partitioning behavior; a prerequisite to include the S3 bucket URI for the Glue Data Catalog base location; updates to cluster configuration steps and examples (including rpk commands and iceberg-related properties); topic creation/alter examples with redpanda.iceberg.mode; produce/query examples showing AWS Glue/Athena usage and expected data format; and updated placeholders for region, bucket, and credentials. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
|
||
| === Lowercase field names required | ||
|
|
||
| You must use only lowercase field names. AWS Glue automatically converts all table column names to lowercase. Redpanda matches columns by name for schema management, and using uppercase letters can cause errors when Redpanda can't find matching columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace can cause errors... with breaks schema management (end of sentence).
It is certain that it will break.
|
|
||
| === Lowercase field names required | ||
|
|
||
| You must use only lowercase field names. AWS Glue automatically converts all table column names to lowercase. Redpanda relies on exact column name matching to manage schemas, and using uppercase letters can break schema management when Redpanda can't find matching columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You must use only lowercase field names. AWS Glue automatically converts all table column names to lowercase. Redpanda relies on exact column name matching to manage schemas, and using uppercase letters can break schema management when Redpanda can't find matching columns. | |
| Use only lowercase field names. AWS Glue converts all table column names to lowercase, and Redpanda requires exact column name matches for schema management. Using uppercase letters will prevent Redpanda from finding matching columns and break schema management. |
Slight change to enforce active voice. Feel free to reject parts that you don't agree
paulohtb6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit on wording.
|
🔥 |
Description
This pull request adds an important clarification to the documentation for AWS Glue integration, specifically regarding field naming requirements. The update highlights a limitation that requires all table column names to be lowercase to avoid schema matching errors.
Documentation update for AWS Glue integration:
Resolves https://redpandadata.atlassian.net/browse/1748
Review deadline:
Page previews
https://deploy-preview-1387--redpanda-docs-preview.netlify.app/current/manage/iceberg/iceberg-topics-aws-glue/#lowercase-field-names-required
Checks