Skip to content

Conversation

@Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Aug 19, 2025

@Feediver1 Feediver1 requested a review from a team as a code owner August 19, 2025 21:00
@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 953eacb
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/68a5c49a8e04ff0008123c6a
😎 Deploy Preview https://deploy-preview-1326--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Wrapped the prerequisite bullet “A valid Redpanda Enterprise license” in an AsciiDoc not-cloud conditional (ifndef::env-cloud[] ... endif[]), so it only appears when env-cloud is not defined. No other content in the document was modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • tmgstevens
  • micheleRP
  • mattschumpert
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Feediver1-patch-3

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Feediver1 Feediver1 changed the title Update schema-reg-authorization.adoc to conditionalize out the enterprise license prereq Update schema-reg-authorization.adoc to conditionalize out the enterprise license prereq for cloud Aug 19, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc (1)

199-202: Good conditionalization; remove extra blank line to avoid splitting the list

Wrapping the Enterprise license prerequisite in ifndef::env-cloud[] is correct and consistent with the rest of the doc. Minor nit: the extra blank line on Line 202 will split the unordered list into two separate lists in non-cloud builds, causing extra vertical spacing.

You can safely remove Line 202 because there’s already a blank line at Line 198 separating the paragraph from the list, which also preserves correct formatting when the gated bullet is hidden.

 ifndef::env-cloud[]
 * A valid Redpanda Enterprise license
 endif::[]
-
 
 * `rpk` v25.2+
 * Cluster administrator permissions to modify cluster configuration
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d7dc5c0 and d936917.

📒 Files selected for processing (1)
  • modules/manage/pages/schema-reg/schema-reg-authorization.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc (1)

388-388: Tag region closing matches the opening tag

The // end::single-source[] correctly pairs with the // tag::single-source[] at Line 5. No issues.

paulohtb6
paulohtb6 previously approved these changes Aug 19, 2025
@paulohtb6
Copy link
Collaborator

This part should probably be conditionalized out too

The `Invalid license: not present` error indicates that the user is trying to create an ACL for a resource that requires a license, but no license is present. See xref:get-started:licensing/overview.adoc[Licensing overview] for details on how to obtain a license.

@paulohtb6
Copy link
Collaborator

@paulohtb6 paulohtb6 self-requested a review August 19, 2025 22:24
conditionalize out the enterprise license prereq
@Feediver1 Feediver1 merged commit aeec251 into main Aug 20, 2025
7 checks passed
@Feediver1 Feediver1 deleted the Feediver1-patch-3 branch August 20, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants