-
Notifications
You must be signed in to change notification settings - Fork 48
Update schema-reg-authorization.adoc to conditionalize out the enterprise license prereq for cloud #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughWrapped the prerequisite bullet “A valid Redpanda Enterprise license” in an AsciiDoc not-cloud conditional (ifndef::env-cloud[] ... endif[]), so it only appears when env-cloud is not defined. No other content in the document was modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc (1)
199-202: Good conditionalization; remove extra blank line to avoid splitting the listWrapping the Enterprise license prerequisite in
ifndef::env-cloud[]is correct and consistent with the rest of the doc. Minor nit: the extra blank line on Line 202 will split the unordered list into two separate lists in non-cloud builds, causing extra vertical spacing.You can safely remove Line 202 because there’s already a blank line at Line 198 separating the paragraph from the list, which also preserves correct formatting when the gated bullet is hidden.
ifndef::env-cloud[] * A valid Redpanda Enterprise license endif::[] - * `rpk` v25.2+ * Cluster administrator permissions to modify cluster configuration
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc (1)
388-388: Tag region closing matches the opening tagThe
// end::single-source[]correctly pairs with the// tag::single-source[]at Line 5. No issues.
|
This part should probably be conditionalized out too
|
conditionalize out the enterprise license prereq
d936917 to
953eacb
Compare
Description
Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Page previews
https://deploy-preview-1326--redpanda-docs-preview.netlify.app/redpanda-cloud/manage/schema-reg/schema-reg-authorization/#prerequisites
https://deploy-preview-1326--redpanda-docs-preview.netlify.app/current/manage/schema-reg/schema-reg-authorization/#prerequisites
Checks