-
Notifications
You must be signed in to change notification settings - Fork 47
Fix GitHub Action #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Action #1234
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/get-cloud-api-spec.yml (1)
54-55
: Extra space after-d
is harmless but untidy—remove for consistencyLine 55 contains two spaces between
-d
andmodules/ROOT/attachments
. While it won’t break the command, trimming the redundant whitespace keeps scripts clean and prevents accidental path typos in future edits.- npx doc-tools fetch -o redpanda-data -r cloudv2 -p proto/gen/openapi/openapi.dataplane.prod.yaml -d modules/ROOT/attachments -f cloud-dataplane-api.yaml + npx doc-tools fetch -o redpanda-data -r cloudv2 -p proto/gen/openapi/openapi.dataplane.prod.yaml -d modules/ROOT/attachments -f cloud-dataplane-api.yaml
Description
This pull request updates the script in the
get-cloud-api-spec.yml
workflow to include a missing flag for thedoc-tools fetch
command. This change ensures that the output files are correctly specified during the fetch process.Workflow script update:
.github/workflows/get-cloud-api-spec.yml
: Added the-f
flag to thedoc-tools fetch
command for both the control plane and data plane API specifications to explicitly specify the output file names (cloud-controlplane-api.yaml
andcloud-dataplane-api.yaml
).Page previews
Checks