-
Couldn't load subscription status.
- Fork 47
Add docs for extraClusterConfig #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sans the comment on reset-object-storage.
| @@ -0,0 +1,2 @@ | |||
| CAUTION: Do not set an object storage property to an empty string (`""`) or `null` to reset it. This may result in invalid or incomplete configuration. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooooo, so this is tricky. By default unsetting a key will NOT unset the cluster config value as that's been the historical behavior for quite a while now. We recently added an annotation that will opt you into being fully declarative.
I think we should update this to point users at rpk cluster config set (though I'm not sure if that can actually unset a value 🤔 ) or denote the annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Chris. Does this change cover it? 89b36a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, LGTM!
Co-authored-by: Chris Seto <[email protected]>
|
|
||
| - Reusability: Centralize common values used by multiple features. | ||
|
|
||
| - Maintainability: Integrate more cleanly with GitOps workflows and Kubernetes-native resource management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my ear, "Integrate more cleanly" feels a little awkward. Can you use "Integrate more seamlessly" or "Better integrate"?
|
|
||
| - Reusability: Centralize common values used by multiple features. | ||
|
|
||
| - Maintainability: Integrate more cleanly with GitOps workflows and Kubernetes-native resource management. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my ear, "Integrate more cleanly" feels a little awkward. Can you use "Integrate more seamlessly" or "Better integrate"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple little suggestions
Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Chris Seto <[email protected]> Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Chris Seto <[email protected]> Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Chris Seto <[email protected]> Co-authored-by: Michele Cyran <[email protected]>
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1460
Review deadline: July 3
Page previews
Checks